Compute D3-tadpole for family of G4-fluxes#4487
Merged
HereAround merged 6 commits intooscar-system:masterfrom Jan 21, 2025
Merged
Compute D3-tadpole for family of G4-fluxes#4487HereAround merged 6 commits intooscar-system:masterfrom
HereAround merged 6 commits intooscar-system:masterfrom
Conversation
98af27e to
c3fc621
Compare
2e6c981 to
418c331
Compare
72a01f1 to
afde8b0
Compare
fingolfin
reviewed
Jan 20, 2025
| function d3_tadpole_constraint(fgs::FamilyOfG4Fluxes; check::Bool = true) | ||
|
|
||
| # Is the result known? | ||
| if has_attribute(fgs, :d3_tadpole_constraint) |
Member
There was a problem hiding this comment.
Ideally this should use the new @attr variant as in #4476
Member
Author
There was a problem hiding this comment.
I have an eye on it. Once the new @attr is available I am happy to update. (Am in fact looking forward to the adaptations made by @lgoettgens . Thx!)
fingolfin
reviewed
Jan 20, 2025
fingolfin
reviewed
Jan 20, 2025
Member
fingolfin
left a comment
There was a problem hiding this comment.
Just a few quick comments. All optional, feel free to ignore
afde8b0 to
19c19fb
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4487 +/- ##
==========================================
+ Coverage 84.40% 84.55% +0.14%
==========================================
Files 672 672
Lines 88737 88863 +126
==========================================
+ Hits 74901 75134 +233
+ Misses 13836 13729 -107
|
Co-authored-by: Max Horn <max@quendi.de>
05b9d80 to
03c24f5
Compare
Member
Author
Thank you! :) |
emikelsons
approved these changes
Jan 21, 2025
Collaborator
emikelsons
left a comment
There was a problem hiding this comment.
Looks good and the tests pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
inter_dictis loaded in asDict{NTuple{4, Int64}, ZZRingElem}.MPolyBuildCtxbuilder for creation of the tadpole polynomial.cc @apturner @emikelsons