Skip to content

Compute D3-tadpole for family of G4-fluxes#4487

Merged
HereAround merged 6 commits intooscar-system:masterfrom
HereAround:ComputeTadpole
Jan 21, 2025
Merged

Compute D3-tadpole for family of G4-fluxes#4487
HereAround merged 6 commits intooscar-system:masterfrom
HereAround:ComputeTadpole

Conversation

@HereAround
Copy link
Copy Markdown
Member

@HereAround HereAround commented Jan 19, 2025

  • Implement D3-tadpole for family of G4-fluxes.
  • Serialize the D3-tadpole for special families of G4-fluxes.
  • Support D3-tadpole also for individual G4-fluxes.
  • General code improvements.
  • Ensure that inter_dict is loaded in as Dict{NTuple{4, Int64}, ZZRingElem}.
  • Use MPolyBuildCtx builder for creation of the tadpole polynomial.

cc @apturner @emikelsons

@HereAround HereAround changed the title Compute tadpole [FtheoryTools] Compute D3-tadpole for family of G4-fluxes Jan 19, 2025
@HereAround HereAround added topic: FTheoryTools enhancement New feature or request WIP NOT ready for merging labels Jan 19, 2025
@HereAround HereAround changed the title [FtheoryTools] Compute D3-tadpole for family of G4-fluxes [FTheoryTools] Compute D3-tadpole for family of G4-fluxes Jan 19, 2025
@HereAround HereAround force-pushed the ComputeTadpole branch 2 times, most recently from 98af27e to c3fc621 Compare January 19, 2025 16:05
@HereAround HereAround marked this pull request as ready for review January 19, 2025 16:07
@HereAround HereAround removed the WIP NOT ready for merging label Jan 19, 2025
@HereAround HereAround force-pushed the ComputeTadpole branch 3 times, most recently from 2e6c981 to 418c331 Compare January 19, 2025 19:12
@HereAround HereAround marked this pull request as draft January 19, 2025 19:20
@HereAround HereAround added the WIP NOT ready for merging label Jan 19, 2025
@HereAround HereAround force-pushed the ComputeTadpole branch 2 times, most recently from 72a01f1 to afde8b0 Compare January 19, 2025 20:01
function d3_tadpole_constraint(fgs::FamilyOfG4Fluxes; check::Bool = true)

# Is the result known?
if has_attribute(fgs, :d3_tadpole_constraint)
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally this should use the new @attr variant as in #4476

Copy link
Copy Markdown
Member Author

@HereAround HereAround Jan 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have an eye on it. Once the new @attr is available I am happy to update. (Am in fact looking forward to the adaptations made by @lgoettgens . Thx!)

Comment thread experimental/FTheoryTools/src/FamilyOfG4Fluxes/attributes.jl Outdated
Copy link
Copy Markdown
Member

@fingolfin fingolfin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few quick comments. All optional, feel free to ignore

Comment thread experimental/FTheoryTools/src/FamilyOfG4Fluxes/attributes.jl Outdated
Comment thread experimental/FTheoryTools/src/FamilyOfG4Fluxes/attributes.jl Outdated
Comment thread experimental/FTheoryTools/src/FamilyOfG4Fluxes/attributes.jl Outdated
Comment thread experimental/FTheoryTools/src/G4Fluxes/attributes.jl Outdated
Comment thread experimental/FTheoryTools/src/G4Fluxes/properties.jl Outdated
@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 21, 2025

Codecov Report

Attention: Patch coverage is 43.93939% with 74 lines in your changes missing coverage. Please review.

Project coverage is 84.55%. Comparing base (9642ba2) to head (f33fe95).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
...eoryTools/src/Serialization/hypersurface_models.jl 0.00% 19 Missing ⚠️
...ntal/FTheoryTools/src/Serialization/tate_models.jl 0.00% 19 Missing ⚠️
...heoryTools/src/Serialization/weierstrass_models.jl 0.00% 19 Missing ⚠️
...al/FTheoryTools/src/FamilyOfG4Fluxes/attributes.jl 74.54% 14 Missing ⚠️
...perimental/FTheoryTools/src/G4Fluxes/attributes.jl 80.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4487      +/-   ##
==========================================
+ Coverage   84.40%   84.55%   +0.14%     
==========================================
  Files         672      672              
  Lines       88737    88863     +126     
==========================================
+ Hits        74901    75134     +233     
+ Misses      13836    13729     -107     
Files with missing lines Coverage Δ
...Tools/src/FamilyOfG4Fluxes/special_constructors.jl 77.11% <100.00%> (ø)
...perimental/FTheoryTools/src/G4Fluxes/properties.jl 100.00% <100.00%> (+1.53%) ⬆️
...perimental/FTheoryTools/src/G4Fluxes/attributes.jl 82.35% <80.00%> (-17.65%) ⬇️
...al/FTheoryTools/src/FamilyOfG4Fluxes/attributes.jl 75.86% <74.54%> (-24.14%) ⬇️
...eoryTools/src/Serialization/hypersurface_models.jl 46.09% <0.00%> (-7.55%) ⬇️
...ntal/FTheoryTools/src/Serialization/tate_models.jl 52.34% <0.00%> (-8.57%) ⬇️
...heoryTools/src/Serialization/weierstrass_models.jl 45.31% <0.00%> (-7.42%) ⬇️

... and 4 files with indirect coverage changes

Co-authored-by: Max Horn <max@quendi.de>
@HereAround HereAround marked this pull request as ready for review January 21, 2025 16:12
@HereAround HereAround removed the WIP NOT ready for merging label Jan 21, 2025
@HereAround
Copy link
Copy Markdown
Member Author

Just a few quick comments. All optional, feel free to ignore

Thank you! :)

Copy link
Copy Markdown
Collaborator

@emikelsons emikelsons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and the tests pass.

@HereAround HereAround merged commit 4bcd2d8 into oscar-system:master Jan 21, 2025
@HereAround HereAround deleted the ComputeTadpole branch January 21, 2025 19:06
@aaruni96 aaruni96 added the release notes: use title For PRs: the title of this PR is suitable for direct use in the release notes label Jan 30, 2025
@fingolfin fingolfin changed the title [FTheoryTools] Compute D3-tadpole for family of G4-fluxes Compute D3-tadpole for family of G4-fluxes Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request release notes: use title For PRs: the title of this PR is suitable for direct use in the release notes topic: FTheoryTools

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants