Rename blowup and blow_up_points to blow_up and blow_up_points, and other intersection theory changes

[wdecker]

Intersection theory:

• blowup --> blow_up
• add more text and examples to docu
• in particular, start documenting code connected to Bott's formula

ping @pbelmans, @thofma

[codecov]

Codecov Report

Attention: Patch coverage is 88.23529% with 2 lines in your changes missing coverage. Please review.

Project coverage is 84.40%. Comparing base (eb35e0e) to head (8ddc947).
Report is 89 commits behind head on master.

Files with missing lines	Patch %	Lines
experimental/IntersectionTheory/src/Bott.jl	83.33%	2 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #4526   +/-   ##
=======================================
  Coverage   84.40%   84.40%           
=======================================
  Files         672      672           
  Lines       89126    89143   +17     
=======================================
+ Hits        75225    75242   +17     
  Misses      13901    13901           

Files with missing lines	Coverage Δ
...ental/IntersectionTheory/src/IntersectionTheory.jl	100.00% <ø> (ø)
experimental/IntersectionTheory/src/Main.jl	93.27% <ø> (ø)
experimental/IntersectionTheory/src/blowup.jl	98.85% <100.00%> (ø)
experimental/IntersectionTheory/src/Bott.jl	74.01% <83.33%> (+6.78%)	⬆️

... and 9 files with indirect coverage changes

[simonbrandhorst]

Thanks for renaming the method blowup(...) to blow_up(...).
It seems that in some places such as here, the word blowup was changed as well, where it is not a function name but a just mathematical terminology. Maybe these changes were unintended?

[wdecker]

@simonbrandhorst thanks; reversed with 1d22cc0

[simonbrandhorst]

Please double check the spelling of "fix points" I believe it is 'fixed points'.

[fingolfin]

Maybe this?

Suggested change

	The OSCAR type for abstract varieties is `AbstractVarietyMap`.
	The OSCAR type for abstract variety maps is `AbstractVarietyMap`.

[fingolfin]

Suggested change

	# Blow_Ups
	# Blow Ups

[fingolfin]

Shouldn't the capitalization here and elsewhere be like this?

Suggested change

	Lines on a General Cubic Hypersurface in $\mathbb P^3$
	Lines on a general cubic hypersurface in $\mathbb P^3$

Or maybe this is meant to be like a headline -- but then I'd also expect it to be boldface, or maybe an actual sub^N-section:

Suggested change

	Lines on a General Cubic Hypersurface in $\mathbb P^3$
	##### Lines on a General Cubic Hypersurface in $\mathbb P^3$

[fingolfin]

Suggested change

	tn_variety(n::Int, points::Vector{Pair{P, Int}}) where P = TnVariety(n::Int, points::Vector{Pair{P, Int}}) where P
	tn_variety(n::Int, points::Vector{Pair{P, Int}}) where P = TnVariety(n::Int, points::Vector{Pair{P, Int}})