Skip to content

Add lattice of one-parameter subgroups#4529

Merged
HereAround merged 2 commits intooscar-system:masterfrom
paemurru:ep/lattice_of_one_parameter_subgroups
Feb 3, 2025
Merged

Add lattice of one-parameter subgroups#4529
HereAround merged 2 commits intooscar-system:masterfrom
paemurru:ep/lattice_of_one_parameter_subgroups

Conversation

@paemurru
Copy link
Copy Markdown
Collaborator

@paemurru paemurru commented Feb 1, 2025

In toric geometry, the character lattice and the lattice of one-parameter subgroups are dual to each other. Confusingly, sometimes the character lattice was used where the lattice of one-parameter subgroups should have been used. This pull request fixes this.

In toric geometry, the character lattice and the lattice of one-parameter subgroups are dual to each other. Confusingly, sometimes the character lattice was used where the lattice of one-parameter subgroups should have been used. This pull request fixes this.
@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 1, 2025

Codecov Report

Attention: Patch coverage is 74.28571% with 9 lines in your changes missing coverage. Please review.

Project coverage is 84.39%. Comparing base (351c1fb) to head (720e746).
Report is 87 commits behind head on master.

Files with missing lines Patch % Lines
...etry/ToricVarieties/ToricMorphisms/constructors.jl 73.91% 6 Missing ⚠️
experimental/Schemes/src/ToricBlowups/types.jl 57.14% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4529      +/-   ##
==========================================
- Coverage   84.40%   84.39%   -0.01%     
==========================================
  Files         672      672              
  Lines       89134    89135       +1     
==========================================
- Hits        75230    75228       -2     
- Misses      13904    13907       +3     
Files with missing lines Coverage Δ
...xperimental/Schemes/src/ToricBlowups/attributes.jl 93.54% <100.00%> (ø)
.../ToricVarieties/NormalToricVarieties/attributes.jl 98.67% <100.00%> (+<0.01%) ⬆️
...ometry/ToricVarieties/ToricMorphisms/attributes.jl 80.21% <100.00%> (ø)
src/deprecations.jl 0.00% <ø> (ø)
experimental/Schemes/src/ToricBlowups/types.jl 72.72% <57.14%> (ø)
...etry/ToricVarieties/ToricMorphisms/constructors.jl 67.85% <73.91%> (ø)

... and 2 files with indirect coverage changes

Comment thread src/deprecations.jl
@simonbrandhorst
Copy link
Copy Markdown
Collaborator

Looks good to me.

@lgoettgens lgoettgens added the release notes: to be added PRs introducing changes that should be (but have not yet been) mentioned in the release notes label Feb 3, 2025
@HereAround HereAround changed the title Add lattice of one-parameter subgroups [ToricVarieties] Add lattice of one-parameter subgroups Feb 3, 2025
Comment thread src/deprecations.jl
Copy link
Copy Markdown
Member

@HereAround HereAround left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on this @paemurru . Looks good to me!

@HereAround HereAround merged commit 0a759cd into oscar-system:master Feb 3, 2025
@paemurru paemurru deleted the ep/lattice_of_one_parameter_subgroups branch February 3, 2025 09:44
@fingolfin fingolfin added release notes: use title For PRs: the title of this PR is suitable for direct use in the release notes and removed release notes: to be added PRs introducing changes that should be (but have not yet been) mentioned in the release notes labels Feb 27, 2025
@fingolfin fingolfin changed the title [ToricVarieties] Add lattice of one-parameter subgroups Add lattice of one-parameter subgroups Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release notes: use title For PRs: the title of this PR is suitable for direct use in the release notes topic: toric geometry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants