Add lattice of one-parameter subgroups#4529
Merged
HereAround merged 2 commits intooscar-system:masterfrom Feb 3, 2025
Merged
Conversation
In toric geometry, the character lattice and the lattice of one-parameter subgroups are dual to each other. Confusingly, sometimes the character lattice was used where the lattice of one-parameter subgroups should have been used. This pull request fixes this.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4529 +/- ##
==========================================
- Coverage 84.40% 84.39% -0.01%
==========================================
Files 672 672
Lines 89134 89135 +1
==========================================
- Hits 75230 75228 -2
- Misses 13904 13907 +3
|
lgoettgens
reviewed
Feb 2, 2025
Collaborator
|
Looks good to me. |
HereAround
reviewed
Feb 3, 2025
HereAround
approved these changes
Feb 3, 2025
Member
HereAround
left a comment
There was a problem hiding this comment.
Thank you for working on this @paemurru . Looks good to me!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In toric geometry, the character lattice and the lattice of one-parameter subgroups are dual to each other. Confusingly, sometimes the character lattice was used where the lattice of one-parameter subgroups should have been used. This pull request fixes this.