Skip to content

Add weyl_group(::Matrix{<:IntegerUnion}) convenience constructor#4536

Merged
simonbrandhorst merged 1 commit intooscar-system:masterfrom
lgoettgens:lg/weyl-group-gcm-Int
Feb 4, 2025
Merged

Add weyl_group(::Matrix{<:IntegerUnion}) convenience constructor#4536
simonbrandhorst merged 1 commit intooscar-system:masterfrom
lgoettgens:lg/weyl-group-gcm-Int

Conversation

@lgoettgens
Copy link
Copy Markdown
Member

Resolves #4473.

cc @TWiedemann

@lgoettgens lgoettgens added enhancement New feature or request topic: lie theory labels Feb 4, 2025
@lgoettgens lgoettgens requested a review from fingolfin February 4, 2025 12:32
@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.40%. Comparing base (069bd41) to head (1736eca).
Report is 82 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4536      +/-   ##
==========================================
- Coverage   84.41%   84.40%   -0.01%     
==========================================
  Files         672      672              
  Lines       89155    89157       +2     
==========================================
  Hits        75256    75256              
- Misses      13899    13901       +2     
Files with missing lines Coverage Δ
src/LieTheory/RootSystem.jl 88.86% <100.00%> (ø)
src/LieTheory/WeylGroup.jl 92.85% <100.00%> (+0.04%) ⬆️

... and 1 file with indirect coverage changes

@simonbrandhorst simonbrandhorst merged commit e881004 into oscar-system:master Feb 4, 2025
@lgoettgens lgoettgens deleted the lg/weyl-group-gcm-Int branch February 4, 2025 17:32
@fingolfin fingolfin added the release notes: use title For PRs: the title of this PR is suitable for direct use in the release notes label Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request release notes: use title For PRs: the title of this PR is suitable for direct use in the release notes topic: lie theory

Projects

None yet

Development

Successfully merging this pull request may close these issues.

weyl_group constructor for Cartan matrix over Int

3 participants