Skip to content

Support for computing automorphism groups of Enriques surfaces#4540

Merged
simonbrandhorst merged 30 commits intomasterfrom
sb/enriques_wip
Feb 6, 2025
Merged

Support for computing automorphism groups of Enriques surfaces#4540
simonbrandhorst merged 30 commits intomasterfrom
sb/enriques_wip

Conversation

@simonbrandhorst
Copy link
Copy Markdown
Collaborator

First version for the computation of automorphism groups of Enriques surfaces

@simonbrandhorst simonbrandhorst marked this pull request as ready for review February 5, 2025 19:15
@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 5, 2025

Codecov Report

Attention: Patch coverage is 85.91224% with 61 lines in your changes missing coverage. Please review.

Project coverage is 84.42%. Comparing base (a6b2c73) to head (a8562a6).
Report is 78 commits behind head on master.

Files with missing lines Patch % Lines
src/AlgebraicGeometry/Surfaces/EnriquesAut.jl 85.74% 61 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           master    #4540    +/-   ##
========================================
  Coverage   84.42%   84.42%            
========================================
  Files         672      673     +1     
  Lines       89193    89624   +431     
========================================
+ Hits        75304    75668   +364     
- Misses      13889    13956    +67     
Files with missing lines Coverage Δ
src/AlgebraicGeometry/Surfaces/K3Auto.jl 93.31% <100.00%> (+<0.01%) ⬆️
src/Groups/matrices/form_group.jl 97.56% <ø> (ø)
src/Groups/spinor_norms.jl 82.91% <100.00%> (ø)
src/Oscar.jl 65.33% <100.00%> (+0.94%) ⬆️
src/AlgebraicGeometry/Surfaces/EnriquesAut.jl 85.74% <85.74%> (ø)

... and 2 files with indirect coverage changes

Comment thread src/AlgebraicGeometry/Surfaces/EnriquesAut.jl Outdated
Comment thread src/AlgebraicGeometry/Surfaces/EnriquesAut.jl Outdated
Comment thread src/AlgebraicGeometry/Surfaces/EnriquesAut.jl Outdated
Comment thread src/AlgebraicGeometry/Surfaces/EnriquesAut.jl Outdated
Comment thread src/AlgebraicGeometry/Surfaces/EnriquesAut.jl Outdated
Comment thread src/AlgebraicGeometry/Surfaces/EnriquesAut.jl Outdated
Comment thread src/AlgebraicGeometry/Surfaces/EnriquesAut.jl Outdated
Comment thread src/AlgebraicGeometry/Surfaces/EnriquesAut.jl Outdated
Comment thread src/AlgebraicGeometry/Surfaces/EnriquesAut.jl Outdated
Comment thread src/exports.jl Outdated
Comment thread test/AlgebraicGeometry/Surfaces/EnriquesAut.jl Outdated
Co-authored-by: Stevell Muller <78619134+StevellM@users.noreply.github.com>
Copy link
Copy Markdown
Collaborator

@HechtiDerLachs HechtiDerLachs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't say much about the mathematics, but it looks rather fine.

I left some comments. Since there is a paper related to this: Is there maybe some example from the paper one could explicitly reproduce in the tests? Just to make the ties to the actual mathematics easier to get for the reader of the code.

Comment thread docs/src/AlgebraicGeometry/Surfaces/EnriquesSurfaces.md Outdated
Comment thread src/AlgebraicGeometry/Surfaces/EnriquesAut.jl Outdated
Comment thread src/AlgebraicGeometry/Surfaces/EnriquesAut.jl Outdated
Comment thread src/AlgebraicGeometry/Surfaces/EnriquesAut.jl Outdated
Comment thread src/AlgebraicGeometry/Surfaces/EnriquesAut.jl Outdated
Comment thread src/AlgebraicGeometry/Surfaces/EnriquesAut.jl Outdated
Comment thread src/AlgebraicGeometry/Surfaces/EnriquesAut.jl
Comment thread src/Groups/spinor_norms.jl Outdated
Comment thread src/exports.jl
Comment thread src/exports.jl Outdated
simonbrandhorst and others added 5 commits February 6, 2025 15:23
Co-authored-by: Matthias Zach <85350711+HechtiDerLachs@users.noreply.github.com>
Co-authored-by: Matthias Zach <85350711+HechtiDerLachs@users.noreply.github.com>
@simonbrandhorst
Copy link
Copy Markdown
Collaborator Author

O.K. I will add a database of Enriques surfaces ... but in another pull request.

Copy link
Copy Markdown
Member

@lgoettgens lgoettgens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some random comments. I have no knowledge at all about the mathematics involved, these are just some minor style things and performance improvements.

Comment thread docs/oscar_references.bib
Comment thread docs/oscar_references.bib Outdated
Comment thread docs/oscar_references.bib Outdated
Comment thread docs/oscar_references.bib Outdated
Comment thread docs/oscar_references.bib Outdated
Comment thread src/AlgebraicGeometry/Surfaces/EnriquesAut.jl Outdated
Comment thread src/AlgebraicGeometry/Surfaces/EnriquesAut.jl Outdated
Comment thread src/AlgebraicGeometry/Surfaces/EnriquesAut.jl Outdated
Comment thread src/exports.jl Outdated
Comment thread src/exports.jl Outdated
simonbrandhorst and others added 2 commits February 6, 2025 15:57
Co-authored-by: Lars Göttgens <lars.goettgens@rwth-aachen.de>
Co-authored-by: Lars Göttgens <lars.goettgens@rwth-aachen.de>
simonbrandhorst and others added 9 commits February 6, 2025 16:03
Co-authored-by: Lars Göttgens <lars.goettgens@rwth-aachen.de>
Co-authored-by: Lars Göttgens <lars.goettgens@rwth-aachen.de>
Co-authored-by: Lars Göttgens <lars.goettgens@rwth-aachen.de>
Co-authored-by: Lars Göttgens <lars.goettgens@rwth-aachen.de>
Co-authored-by: Lars Göttgens <lars.goettgens@rwth-aachen.de>
@simonbrandhorst
Copy link
Copy Markdown
Collaborator Author

I think I have addressed all comments. Please merge. And thanks for all the feedback!

@simonbrandhorst simonbrandhorst enabled auto-merge (squash) February 6, 2025 15:28
@simonbrandhorst simonbrandhorst merged commit ca6338c into master Feb 6, 2025
@simonbrandhorst simonbrandhorst deleted the sb/enriques_wip branch February 6, 2025 17:28
@fingolfin fingolfin changed the title Automorphism Groups of Enriques surfaces Add support for computing automorphism groups of Enriques surfaces Feb 27, 2025
@fingolfin fingolfin added enhancement New feature or request release notes: use title For PRs: the title of this PR is suitable for direct use in the release notes labels Feb 27, 2025
@fingolfin fingolfin changed the title Add support for computing automorphism groups of Enriques surfaces Support for computing automorphism groups of Enriques surfaces Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request release notes: use title For PRs: the title of this PR is suitable for direct use in the release notes topic: algebraic geometry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants