Support for computing automorphism groups of Enriques surfaces#4540
Merged
simonbrandhorst merged 30 commits intomasterfrom Feb 6, 2025
Merged
Support for computing automorphism groups of Enriques surfaces#4540simonbrandhorst merged 30 commits intomasterfrom
simonbrandhorst merged 30 commits intomasterfrom
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4540 +/- ##
========================================
Coverage 84.42% 84.42%
========================================
Files 672 673 +1
Lines 89193 89624 +431
========================================
+ Hits 75304 75668 +364
- Misses 13889 13956 +67
|
simonbrandhorst
commented
Feb 6, 2025
StevellM
reviewed
Feb 6, 2025
Co-authored-by: Stevell Muller <78619134+StevellM@users.noreply.github.com>
Collaborator
HechtiDerLachs
left a comment
There was a problem hiding this comment.
Can't say much about the mathematics, but it looks rather fine.
I left some comments. Since there is a paper related to this: Is there maybe some example from the paper one could explicitly reproduce in the tests? Just to make the ties to the actual mathematics easier to get for the reader of the code.
Co-authored-by: Matthias Zach <85350711+HechtiDerLachs@users.noreply.github.com>
Co-authored-by: Matthias Zach <85350711+HechtiDerLachs@users.noreply.github.com>
Collaborator
Author
|
O.K. I will add a database of Enriques surfaces ... but in another pull request. |
lgoettgens
reviewed
Feb 6, 2025
Co-authored-by: Lars Göttgens <lars.goettgens@rwth-aachen.de>
Co-authored-by: Lars Göttgens <lars.goettgens@rwth-aachen.de>
Co-authored-by: Lars Göttgens <lars.goettgens@rwth-aachen.de>
Co-authored-by: Lars Göttgens <lars.goettgens@rwth-aachen.de>
Co-authored-by: Lars Göttgens <lars.goettgens@rwth-aachen.de>
Co-authored-by: Lars Göttgens <lars.goettgens@rwth-aachen.de>
Co-authored-by: Lars Göttgens <lars.goettgens@rwth-aachen.de>
Collaborator
Author
|
I think I have addressed all comments. Please merge. And thanks for all the feedback! |
HechtiDerLachs
approved these changes
Feb 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First version for the computation of automorphism groups of Enriques surfaces