Update Singular.jl to 0.25.0

[hannes14]

No description provided.

[fingolfin]

The regular tests also have failures:

      From worker 7:	primary decomposition in graded rings: Test Failed at /home/oscarci-tester/oscar-runners/runner-15/_work/Oscar.jl/Oscar.jl/test/Rings/mpoly.jl:435
      From worker 7:	  Expression: length(dec) == 2
      From worker 7:	   Evaluated: 1 == 2

That looks suspicious.

[fingolfin]

So I had a look at the failing test.

Common setup:

julia> Pt, t = QQ[:t]
(Univariate polynomial ring in t over QQ, t)

julia> f = t^2 + 1
t^2 + 1

julia> kk, i = number_field(f)
(Number field of degree 2 over QQ, _a)

julia> R, (x, y) = kk[:x, :y]
(Multivariate polynomial ring in 2 variables over kk, AbstractAlgebra.Generic.MPoly{AbsSimpleNumFieldElem}[x, y])

julia> S, _ = grade(R)
(Graded multivariate polynomial ring in 2 variables over kk, MPolyDecRingElem{AbsSimpleNumFieldElem, AbstractAlgebra.Generic.MPoly{AbsSimpleNumFieldElem}}[x, y])

julia> I = ideal(S, [x^2 + y^2])
Ideal generated by
  x^2 + y^2

Primary decomposition on master, i.e. without this PR:

julia> dec = primary_decomposition(I)
2-element Vector{Tuple{MPolyIdeal{MPolyDecRingElem{AbsSimpleNumFieldElem, AbstractAlgebra.Generic.MPoly{AbsSimpleNumFieldElem}}}, MPolyIdeal{MPolyDecRingElem{AbsSimpleNumFieldElem, AbstractAlgebra.Generic.MPoly{AbsSimpleNumFieldElem}}}}}:
 (Ideal (x^2 + y^2, x + _a*y, _a*x - y), Ideal (x^2 + y^2, x + _a*y, _a*x - y))
 (Ideal (x^2 + y^2, -x + _a*y, _a*x + y), Ideal (x^2 + y^2, -x + _a*y, _a*x + y))

And with this PR:

julia> dec = primary_decomposition(I)
1-element Vector{Tuple{MPolyIdeal{MPolyDecRingElem{AbsSimpleNumFieldElem, AbstractAlgebra.Generic.MPoly{AbsSimpleNumFieldElem}}}, MPolyIdeal{MPolyDecRingElem{AbsSimpleNumFieldElem, AbstractAlgebra.Generic.MPoly{AbsSimpleNumFieldElem}}}}}:
 (Ideal (x^2 + y^2), Ideal (x^2 + y^2))

[lgoettgens]

@fingolfin I think hannes already prepared a fix, that's just waiting for a merge in JuliaPackaging/Yggdrasil#10462.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.06%. Comparing base (3ca33ad) to head (156b746).
Report is 14 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #4548      +/-   ##
==========================================
- Coverage   84.42%   84.06%   -0.36%     
==========================================
  Files         672      673       +1     
  Lines       89193    91973    +2780     
==========================================
+ Hits        75300    77320    +2020     
- Misses      13893    14653     +760     

Files with missing lines	Coverage Δ
src/Rings/mpoly-ideals.jl	86.14% <100.00%> (-8.24%)	⬇️
src/Rings/mpoly-localizations.jl	77.93% <ø> (ø)

... and 61 files with indirect coverage changes

[lgoettgens]

I think it now remains to update two of the book test outputs. @hannes14 could you please take care of that?

[lgoettgens]

The macos doctest failure is #4572.