Skip to content

Align names of properties and attributes among families of and individual G4-fluxes#4562

Merged
HereAround merged 7 commits intooscar-system:masterfrom
HereAround:RenameFunctions
Feb 8, 2025
Merged

Align names of properties and attributes among families of and individual G4-fluxes#4562
HereAround merged 7 commits intooscar-system:masterfrom
HereAround:RenameFunctions

Conversation

@HereAround
Copy link
Copy Markdown
Member

@HereAround HereAround commented Feb 7, 2025

  • passes_elementary_quantization_checks -> is_well_quantized,
  • rename variable base in CI-tests to my_base,
  • passes_verticality_checks -> is_vertical,
  • display forgotten docstrings,
  • introduce function tunable_sections,
  • introduce function model_sections,
  • code improvement.

cc @apturner @emikelsons

@HereAround HereAround added topic: FTheoryTools optimization Simpler/more performant code or more/better tests labels Feb 7, 2025
Copy link
Copy Markdown
Collaborator

@emikelsons emikelsons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and the tests pass

@HereAround HereAround merged commit 210671e into oscar-system:master Feb 8, 2025
@emikelsons emikelsons changed the title [FTheoryTools] Rename some functions Rename some functions Feb 27, 2025
@emikelsons emikelsons added the release notes: use title For PRs: the title of this PR is suitable for direct use in the release notes label Feb 27, 2025
@HereAround HereAround changed the title Rename some functions Align names of properties and attributes among families of and individual G4-fluxes Feb 27, 2025
@HereAround HereAround deleted the RenameFunctions branch November 27, 2025 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

optimization Simpler/more performant code or more/better tests release notes: use title For PRs: the title of this PR is suitable for direct use in the release notes topic: FTheoryTools

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants