Cache parents for permutations in perm, cperm and @perm#4582
Merged
lgoettgens merged 1 commit intomasterfrom Feb 12, 2025
Merged
Cache parents for permutations in perm, cperm and @perm#4582lgoettgens merged 1 commit intomasterfrom
perm, cperm and @perm#4582lgoettgens merged 1 commit intomasterfrom
Conversation
... and generally in functions which create a permutation without
taking a parent as argument.
Before:
julia> g = symmetric_group(4); v = [1,2]; w = [3,4];
julia> @b cperm($g,$v,$w)
888.889 ns (14 allocs: 352 bytes)
julia> @b cperm($v,$w)
12.500 μs (196 allocs: 16.242 KiB)
After:
julia> g = symmetric_group(4); v = [1,2]; w = [3,4];
julia> @b cperm($g,$v,$w)
822.600 ns (14 allocs: 352 bytes)
julia> @b cperm($v,$w)
909.700 ns (14 allocs: 352 bytes)
lgoettgens
approved these changes
Feb 12, 2025
perm, cperm, @perm
perm, cperm, @permperm, cperm and @perm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
... and generally in functions which create a permutation without taking a parent as argument.
Before:
After: