Skip to content

Improve usability of abelian_closure(QQ), e.g. for elements representing real values allow comparisons and conversion to Float64#4585

Merged
fingolfin merged 4 commits intooscar-system:masterfrom
ThomasBreuer:TB_QQab_convenience
Feb 18, 2025
Merged

Improve usability of abelian_closure(QQ), e.g. for elements representing real values allow comparisons and conversion to Float64#4585
fingolfin merged 4 commits intooscar-system:masterfrom
ThomasBreuer:TB_QQab_convenience

Conversation

@ThomasBreuer
Copy link
Copy Markdown
Member

@ThomasBreuer ThomasBreuer commented Feb 12, 2025

resolves #3976

@ThomasBreuer ThomasBreuer added topic: commutative algebra release notes: not needed PRs introducing changes that are wholly irrelevant to the release notes enhancement New feature or request labels Feb 12, 2025
Comment thread docs/src/NumberTheory/abelian_closure.md Outdated
Comment thread src/Rings/AbelianClosure.jl
@ThomasBreuer
Copy link
Copy Markdown
Member Author

The way how n-th roots of unity are printed is irritating:
On the one hand, the documentation says that the default is z(n).
On the other hand, the docstrings show zeta(n).

@thofma
Copy link
Copy Markdown
Collaborator

thofma commented Feb 12, 2025

If the documentation is lying, maybe we could change it? To make it somewhat consistent.

Copy link
Copy Markdown
Member

@fingolfin fingolfin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me, thank you!

Two minor nitpicks...

Comment thread docs/src/NumberTheory/abelian_closure.md Outdated
Comment thread src/Rings/AbelianClosure.jl Outdated
Comment thread src/Rings/AbelianClosure.jl Outdated
Comment thread src/Rings/AbelianClosure.jl Outdated
Comment thread src/Rings/AbelianClosure.jl Outdated
@fingolfin fingolfin enabled auto-merge (squash) February 18, 2025 10:05
@fingolfin fingolfin merged commit e83ef67 into oscar-system:master Feb 18, 2025
@ThomasBreuer ThomasBreuer deleted the TB_QQab_convenience branch February 18, 2025 10:56
@fingolfin fingolfin changed the title Usability wishes for QQab Improve usability of abelian_closure(QQ), e.g. for elements representing real values allow comparisons and conversion to Float64 Feb 27, 2025
@fingolfin fingolfin added release notes: use title For PRs: the title of this PR is suitable for direct use in the release notes and removed release notes: not needed PRs introducing changes that are wholly irrelevant to the release notes labels Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request release notes: use title For PRs: the title of this PR is suitable for direct use in the release notes topic: number theory

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Usability wishes for QQab

3 participants