Experimental: Add braid moves for words in Weyl groups#4687
Merged
lgoettgens merged 12 commits intooscar-system:masterfrom Mar 17, 2025
Merged
Experimental: Add braid moves for words in Weyl groups#4687lgoettgens merged 12 commits intooscar-system:masterfrom
lgoettgens merged 12 commits intooscar-system:masterfrom
Conversation
lgoettgens
reviewed
Mar 4, 2025
Member
lgoettgens
left a comment
lgoettgens
left a comment
There was a problem hiding this comment.
some basic, maybe stupid questions and comments. I think I just don't quite understand what some of these functions are supposed to do. We can also talk in the office tomorrow.
lgoettgens
reviewed
Mar 7, 2025
lgoettgens
changed the title
Co-authored-by: Lars Göttgens <lars.goettgens@gmail.com>
lgoettgens
approved these changes
Mar 17, 2025
Member
lgoettgens
left a comment
lgoettgens
left a comment
There was a problem hiding this comment.
No objections. Everything is in experimental. Let's merge this for now and tune it once there is an application.
lgoettgens
changed the title
lgoettgens
added
experimental
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds 3 new functions currently named
exchange!(W::WeylGroup, w::Vector{UInt8}, i::Int),braid_moves(W::WeylGroup, i::Vector{UInt8}, j::Vector{UInt8}),apply_braid_move!(w::Vector{UInt8}, mv::Tuple{Int,Int,Int}).See docs strings for description of the new functions.
If you have any comments, let me know.