Add convenience constructors for flux instances#4711
Merged
HereAround merged 1 commit intooscar-system:masterfrom Mar 10, 2025
Merged
Add convenience constructors for flux instances#4711HereAround merged 1 commit intooscar-system:masterfrom
HereAround merged 1 commit intooscar-system:masterfrom
Conversation
Member
Author
|
I think that the failures are due to time-outs and not related to the changes in this PR. |
Member
macos failures / timeouts are #4714 |
HereAround
force-pushed
the
MoreFeaturesForFTheoryTools
branch
from
84d4562 to
2b1ba3e
Compare
HereAround
force-pushed
the
MoreFeaturesForFTheoryTools
branch
from
2b1ba3e to
e8e4d78
Compare
HereAround
changed the title
HereAround
added
the
release notes: use title
apturner
approved these changes
Mar 10, 2025
Collaborator
apturner
left a comment
apturner
left a comment
There was a problem hiding this comment.
Thanks @HereAround. I think we want to keep the variants with Vector{Any}, as you and I discussed. There are cases where one of the integer or rational lists of fluxes is empty, so the user needs to supply an empty list, and expecting them to remember to supply Int[] and Rational[] seems like too much to ask of the users.
lgoettgens
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc @apturner @emikelsons