Use Set for GSet block systems#4771
Merged
fingolfin merged 8 commits intooscar-system:masterfrom Apr 2, 2025
Merged
Conversation
Collaborator
Author
|
We still need to document this change properly, and probably add a test that could have caught an error like this. |
Member
|
Concerning a test, what about the example from #4756? |
Collaborator
Author
Yeah, this seems to be the smallest case where we have this issue, so I will put it in. |
fieker
pushed a commit
that referenced
this pull request
May 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we ask for a block system for a
PermGroup(using the methodsblocks,maximal_blocks,minimal_block_reps, orall_blocks), the naturalGSetis the set of integers from 1 to n, this is delegated to GAP and the blocks are returned as sorted vectors of integers, as aGSetwith the GAP actionon_sets.When we call these methods using a
GSetas an argument, we want to convert these integers back to elements of the originalGSet- however in some cases, it means the vectors we have are no longer sorted and so we end up with an error when trying to define the group actionon_sets. In addition, because of the generality allowed in defining aGSet, it may not even be possible to sort these vectors.To address this, we convert the blocks returned by GAP into Julia
Setobjects. This does create a discrepancy in return types between thePermGroupandGSetmethods, but usingSetfeels natural from a mathematical point of view, and allows us to effectively work withGSetsin a very general way.Fixes #4756