Add exceptional classes and indices#4779
Conversation
cbc844b to
598eb1e
Compare
9949a5a to
ad711ff
Compare
|
@apturner if the tests are correct, these changes here somehow break what we stated in our book chapter. But I fail to see exactly what. Any idea? (@emikelsons Did you already rebase to master. Just want to make sure that the Hecke documentation error is gone and not responsible for any of this.) Generally speaking, this looks good to me. |
I did rebase, but if the errors that persist were indeed caused by me - then I'm not sure. I added additional optional arguments to the |
|
Regarding the book tests, one ambient space prints slightly different now: julia> t1 = blow_up(t, [\"x\", \"y\", \"x1\"]; coordinate_name = \"e1\")
Partially resolved global Tate model over a concrete base
julia> amb1 = ambient_space(t1)
- Normal toric variety
+ Normal, simplicial toric varietyRegarding the other tests: This looks like the timeout / IO issues that we have seen quite a bit during this week, this hopefully disappears when re-run when the CI runner is less busy. |
c27ff54 to
3c96c76
Compare
3c96c76 to
38a5adf
Compare
|
It would also be fine to adjust the book-test output to new printing, we never claimed that this would stay unchanged. (assuming the new output is also correct) |
I see, I wasn't familiar with the book test claims and restrictions. This certainly makes things easier as my current fix isn't great |
38a5adf to
7bdb13e
Compare
HereAround
left a comment
There was a problem hiding this comment.
Thank you @emikelsons for working on this!
Added the attributes
exceptional_classesandexceptional_divisor_indicesfor FTheory models for more convenient access to this information. I also made slight improvements to the internal_set_all_attributesmethod.Before this is merged, I would also like to add changes, that would change the
exceptional_classesattribute, whenever a blow up is performed. @HereAround @apturner