Add sanity check for input to tensor_product.#4812
Closed
HechtiDerLachs wants to merge 1 commit intooscar-system:masterfrom
Closed
Add sanity check for input to tensor_product.#4812HechtiDerLachs wants to merge 1 commit intooscar-system:masterfrom
HechtiDerLachs wants to merge 1 commit intooscar-system:masterfrom
Conversation
Member
|
Test fails, so needs work by @HechtiDerLachs |
Member
|
@jankoboehm and @HechtiDerLachs will look into this |
Member
|
Actually, I take this back: this PR is not going to be merged, we will use #4810 and this one here is just left open for reference purposes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Another potential fix for #4809 which introduces an assertion according to what I understood to be @AlexD97 's remark. But it seems to break the tests.