Add CI job that checks for consistent @meta blocks in all md pages#4823
Merged
fingolfin merged 4 commits intooscar-system:masterfrom May 5, 2025
Merged
Add CI job that checks for consistent @meta blocks in all md pages#4823fingolfin merged 4 commits intooscar-system:masterfrom
@meta blocks in all md pages#4823fingolfin merged 4 commits intooscar-system:masterfrom
Conversation
Member
|
I'd rather wish we could just specify a single |
fingolfin
reviewed
Apr 24, 2025
| meta = """```@meta | ||
| CurrentModule = Oscar | ||
| DocTestSetup = Oscar.doctestsetup() | ||
| ``` |
Member
There was a problem hiding this comment.
Aren't there cases where we need the standard block plus something more? In that case it might be better to only match the first three lines?
Suggested change
| ``` |
Member
Author
There was a problem hiding this comment.
I haven't seen such cases yet, so I would only do that once needed.
Member
There was a problem hiding this comment.
My mistake: the example I thought I saw in docs/src/NumberTheory/galois.md isn't one -- that file simply has three @meta blocks, but the primary (first) one is "standard", so this is indeed fine!
fingolfin
reviewed
Apr 24, 2025
Member
|
Needs an update |
lgoettgens
force-pushed
the
lg/CI-check-meta-blocks
branch
from
09f27ea to
7a58d79
Compare
fingolfin
approved these changes
May 5, 2025
fieker
pushed a commit
that referenced
this pull request
May 16, 2025
…4823) To this end, also unify `@meta` blocks
lgoettgens
added
the
release notes: not needed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While looking through the diff of #4758, I noticed that many files have slightly different content in their
@metablocks. This PR adds a simple check that all of them coincide, and if not, prints out a list of files that need adaptation.I deliberately did not attempt to fix these issue yet, as that would produce loads of conflicts with #4758.