Skip to content

[FTheoryTools] Some minor improvements#4844

Merged
HereAround merged 9 commits intooscar-system:masterfrom
HereAround:MoreChanges
May 7, 2025
Merged

[FTheoryTools] Some minor improvements#4844
HereAround merged 9 commits intooscar-system:masterfrom
HereAround:MoreChanges

Conversation

@HereAround
Copy link
Copy Markdown
Member

@HereAround HereAround commented Apr 30, 2025 •
edited
Loading

  • Fix buzzwords for big model (in JSON file)
  • Update big model artifact
  • Update printing of G4-fluxes and families of G4-fluxes
  • Support terse, one-line and detailed printing for all F-theory objects
  • Change "A family..." to "Family..." in agreement with implementations of other OSCAR objects
  • Special flux family does not set the attribute of gauge-group-breaking unless this is known to be unbroken
  • Given an individual G4-flux G, we have a method which computes a family of fluxes, which contains G. Additionally, this computed flux family is as small as possible. (If G does not break the non-Abelian gauge group, then the compute flux family does not break the non-Abelian gauge group neither). This method assigned attributes - specifically the non-Abelian gauge group breaking property - incorrectly to the computed flux family. This is also fixed with this PR. The fix impacts the printing.

Printing of vectors of toric divisors is suuuuper slow for big varieties (= big model). Achieved massive speedup (thx to @lgoettgens (Moved to #4846)

Proposal for release notes text:

  • Improve printing of G4-flux and families thereof.
  • Bug fix in computing smallest containing flux family for a given individual G4-flux.
  • Update .mrdi-files (artifact) for model 1511.03209.

@HereAround HereAround changed the title [FTheoryTools] Fix buzzwords for big model [FTheoryTools] Some minor improvements Apr 30, 2025
@HereAround HereAround mentioned this pull request Apr 30, 2025
Open
@HereAround HereAround added topic: FTheoryTools release notes: to be added PRs introducing changes that should be (but have not yet been) mentioned in the release notes labels Apr 30, 2025
@HereAround HereAround marked this pull request as ready for review April 30, 2025 15:28
@HereAround HereAround requested a review from apturner April 30, 2025 15:29
@HereAround HereAround force-pushed the MoreChanges branch 5 times, most recently from ee5bf2b to afe23c0 Compare May 1, 2025 19:11
@HereAround
Copy link
Copy Markdown
Member Author

HereAround commented May 1, 2025

@apturner This PR now contains the changes we discussed earlier today.

emikelsons
emikelsons approved these changes May 7, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@emikelsons emikelsons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@HereAround HereAround merged commit d09ae46 into oscar-system:master May 7, 2025
32 checks passed
@HereAround HereAround deleted the MoreChanges branch May 7, 2025 11:33
fieker pushed a commit that referenced this pull request May 16, 2025
@HereAround @fieker
[FTheoryTools] Some minor improvements (#4844)
4ccf7b9 
* [FTheoryTools] Fix buzzwords for big model

* [FTheoryTools] Clean up literature model constructor

* [FTheoryTools] Update big model artifact

* [FTheoryTools] Extend extra-long tests

* [FTheoryTools] Update printing of G4-fluxes and flux families

* [FTheoryTools] Support one-line, terse and detailed printing for all objects

* [FTheoryTools] A family of spaces -> Family of spaces (OSCAR convention)

* [FTheoryTools] A family of G4s -> Family of G4s (OSCAR convention)

* [FTheoryTools] Special flux family constructor does not set gauge group unless is known to be unbroken
@lgoettgens lgoettgens mentioned this pull request May 21, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@emikelsons emikelsons emikelsons approved these changes

@apturner apturner Awaiting requested review from apturner

Assignees

No one assigned

Labels

release notes: to be added PRs introducing changes that should be (but have not yet been) mentioned in the release notes topic: FTheoryTools

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@HereAround @emikelsons