Conversation
thofma
changed the title
thofma
added
enhancement
Collaborator
Author
|
@wdecker together with Nemocas/AbstractAlgebra.jl#2072 this should account for improvements you had in mind (hopefully I did not forget one) |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4879 +/- ##
=======================================
Coverage 84.90% 84.91%
=======================================
Files 682 682
Lines 91630 91635 +5
=======================================
+ Hits 77799 77808 +9
+ Misses 13831 13827 -4
🚀 New features to boost your workflow:
|
joschmitt
approved these changes
May 10, 2025
Comment on lines
+21
to
+22
| minpoly, parent_type, promote_rule, roots | ||
| minpoly, parent_type, promote_rule, roots, | ||
| is_perfect |
Member
There was a problem hiding this comment.
This list was in alphabetic order before...
fieker
pushed a commit
that referenced
this pull request
May 16, 2025
lgoettgens
changed the title
is_perfect for algebraic closures of finite fields
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.