Bump AA to v0.45, Nemo to v0.50, Hecke to v0.36#4895
Merged
lgoettgens merged 12 commits intomasterfrom May 19, 2025
Merged
Conversation
lgoettgens
commented
May 17, 2025
| Complex embedding of number field -> 1//2 + Z | ||
| <2> -> 1//2 + Z | ||
| <5> -> 0 + Z | ||
| Real embedding of number field -> 1//2 + Z |
Member
Author
There was a problem hiding this comment.
@thofma is this change here from Complex to Real intended like this?
fingolfin
approved these changes
May 19, 2025
Member
Author
|
This should no longer have any errors in CI (I ran it on different servers with deperrors on and off, different julia versions, some CI jobs here succeeded in earlier iterations). |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4895 +/- ##
==========================================
+ Coverage 84.81% 84.88% +0.06%
==========================================
Files 683 683
Lines 91945 91859 -86
==========================================
- Hits 77984 77975 -9
+ Misses 13961 13884 -77
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release notes
per hand add the following to the respective sections: