Skip to content

Bump AA to v0.45, Nemo to v0.50, Hecke to v0.36#4895

Merged
lgoettgens merged 12 commits intomasterfrom
lg/bump-deps
May 19, 2025
Merged

Bump AA to v0.45, Nemo to v0.50, Hecke to v0.36#4895
lgoettgens merged 12 commits intomasterfrom
lg/bump-deps

Conversation

@lgoettgens
Copy link
Copy Markdown
Member

@lgoettgens lgoettgens commented May 16, 2025

Release notes

per hand add the following to the respective sections:

Bump AbstractAlgebra to v0.45
Bump Nemo to v0.50
Bump Hecke to v0.36
Bump Polymake.jl to 0.12

@lgoettgens lgoettgens added package: Hecke package: Nemo package: AbstractAlgebra release notes: to be added PRs introducing changes that should be (but have not yet been) mentioned in the release notes labels May 16, 2025
Complex embedding of number field -> 1//2 + Z
<2> -> 1//2 + Z
<5> -> 0 + Z
Real embedding of number field -> 1//2 + Z
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thofma is this change here from Complex to Real intended like this?

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

@lgoettgens lgoettgens marked this pull request as ready for review May 19, 2025 14:53
@lgoettgens
Copy link
Copy Markdown
Member Author

This should no longer have any errors in CI (I ran it on different servers with deperrors on and off, different julia versions, some CI jobs here succeeded in earlier iterations).

@lgoettgens lgoettgens requested a review from thofma May 19, 2025 14:54
@codecov
Copy link
Copy Markdown

codecov Bot commented May 19, 2025

Codecov Report

Attention: Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 84.88%. Comparing base (3ba302a) to head (af1ab20).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
...raicGeometry/Surfaces/EllipticSurface/Morphisms.jl 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4895      +/-   ##
==========================================
+ Coverage   84.81%   84.88%   +0.06%     
==========================================
  Files         683      683              
  Lines       91945    91859      -86     
==========================================
- Hits        77984    77975       -9     
+ Misses      13961    13884      -77     
Files with missing lines Coverage Δ
experimental/CliffordAlgOrd/src/CliffordAlgebra.jl 83.81% <100.00%> (ø)
experimental/CliffordAlgOrd/src/CliffordOrder.jl 77.92% <100.00%> (ø)
experimental/GModule/src/GaloisCohomology.jl 67.59% <ø> (ø)
experimental/QAnalogs/src/QAnalogs.jl 100.00% <ø> (ø)
...ntal/QuadFormAndIsom/src/lattices_with_isometry.jl 99.71% <ø> (ø)
...ometry/Surfaces/EllipticSurface/EllipticSurface.jl 83.62% <100.00%> (ø)
...cGeometry/Surfaces/EllipticSurface/NeighborStep.jl 91.92% <100.00%> (ø)
...oricVarieties/NormalToricVarieties/constructors.jl 100.00% <ø> (ø)
src/Combinatorics/Graphs/functions.jl 93.12% <ø> (ø)
src/Misc/MoveToAbstractAlgebra.jl 83.33% <ø> (-8.98%) ⬇️
... and 12 more

... and 5 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lgoettgens lgoettgens merged commit 151d0b2 into master May 19, 2025
32 of 36 checks passed
@lgoettgens lgoettgens deleted the lg/bump-deps branch May 19, 2025 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

package: AbstractAlgebra package: Hecke package: Nemo release notes: to be added PRs introducing changes that should be (but have not yet been) mentioned in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants