Skip to content

IntersectionTheory: Rename abstract_projective_bundle -> projective_bundle and abstract_flag_bundle -> flag_bundle#4899

Merged
thofma merged 1 commit intomasterfrom
th/rename
May 19, 2025
Merged

IntersectionTheory: Rename abstract_projective_bundle -> projective_bundle and abstract_flag_bundle -> flag_bundle#4899
thofma merged 1 commit intomasterfrom
th/rename

Conversation

@thofma
Copy link
Copy Markdown
Collaborator

@thofma thofma commented May 19, 2025

  • abstract_projective_bundle —> projective_bundle
  • abstract_flag_bundle —> flag_bundle

CC: @wdecker

Comment thread experimental/IntersectionTheory/src/IntersectionTheory.jl Outdated
Comment thread experimental/IntersectionTheory/src/IntersectionTheory.jl Outdated
@codecov
Copy link
Copy Markdown

codecov Bot commented May 19, 2025

Codecov Report

Attention: Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.

Project coverage is 84.88%. Comparing base (f862afa) to head (9b940cf).
Report is 14 commits behind head on master.

Files with missing lines Patch % Lines
experimental/IntersectionTheory/src/Main.jl 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4899      +/-   ##
==========================================
- Coverage   84.89%   84.88%   -0.01%     
==========================================
  Files         683      683              
  Lines       91940    91940              
==========================================
- Hits        78051    78043       -8     
- Misses      13889    13897       +8     
Files with missing lines Coverage Δ
...ental/IntersectionTheory/src/IntersectionTheory.jl 100.00% <ø> (ø)
experimental/IntersectionTheory/src/blowup.jl 66.93% <100.00%> (ø)
experimental/IntersectionTheory/src/Main.jl 93.28% <85.71%> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Collaborator

@wdecker wdecker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx!

- abstract_projective_bundle —> projective_bundle
- abstract_flag_bundle —> flag_bundle
@thofma thofma enabled auto-merge (squash) May 19, 2025 15:38
@thofma thofma merged commit 8641dfc into master May 19, 2025
32 of 36 checks passed
@thofma thofma deleted the th/rename branch May 19, 2025 16:35
@lgoettgens lgoettgens added the experimental Only changes experimental parts of the code label May 19, 2025
@joschmitt joschmitt changed the title IntersectionTheory: renaming IntersectionTheory: Rename abstract_projective_bundle -> projective_bundle and abstract_flag_bundle -> flag_bundle May 20, 2025
@joschmitt joschmitt added the release notes: use title For PRs: the title of this PR is suitable for direct use in the release notes label May 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

experimental Only changes experimental parts of the code release notes: use title For PRs: the title of this PR is suitable for direct use in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants