Skip to content

Fix minimal_generating_set for ideals created by a f4 groebner basis#4950

Merged
lgoettgens merged 2 commits intooscar-system:masterfrom
lgoettgens:lg/f4-minimal_generating_set
Jun 3, 2025
Merged

Fix minimal_generating_set for ideals created by a f4 groebner basis#4950
lgoettgens merged 2 commits intooscar-system:masterfrom
lgoettgens:lg/f4-minimal_generating_set

Conversation

@lgoettgens
Copy link
Copy Markdown
Member

@lgoettgens lgoettgens commented Jun 2, 2025

Resolves #4949.

There used to be a singular_assure in the line before the one I edited, but that was removed by @ederc in #2829.

After looking into it for a moment longer, it seems that this line isn't needed at all, as the flag will be set by the singular_generators call in the next line anyway, see

Oscar.jl/src/Rings/mpoly.jl

Lines 389 to 391 in feee19f

if isdefined(B, :ord) && B.ord == monorder
S.isGB = B.isGB
end

@lgoettgens lgoettgens requested review from ederc and jankoboehm June 2, 2025 17:43
@lgoettgens lgoettgens added topic: commutative algebra release notes: use title For PRs: the title of this PR is suitable for direct use in the release notes backport 1.4.x backport for release branch 1.4 labels Jun 2, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.87%. Comparing base (7f923f6) to head (60864b2).
Report is 17 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4950   +/-   ##
=======================================
  Coverage   84.87%   84.87%           
=======================================
  Files         697      697           
  Lines       93925    93925           
=======================================
+ Hits        79721    79722    +1     
+ Misses      14204    14203    -1     
Files with missing lines Coverage Δ
src/Rings/mpoly-graded.jl 93.35% <ø> (+0.45%) ⬆️

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lgoettgens lgoettgens merged commit 33abd3b into oscar-system:master Jun 3, 2025
31 of 35 checks passed
@lgoettgens lgoettgens deleted the lg/f4-minimal_generating_set branch June 3, 2025 07:18
benlorenz pushed a commit that referenced this pull request Jun 5, 2025
@benlorenz benlorenz mentioned this pull request Jun 5, 2025
4 tasks
@benlorenz benlorenz removed the backport 1.4.x backport for release branch 1.4 label Jun 6, 2025
@lgoettgens lgoettgens added the backport 1.4.x done has been backported to release branch 1.4 label Jun 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport 1.4.x done has been backported to release branch 1.4 release notes: use title For PRs: the title of this PR is suitable for direct use in the release notes topic: commutative algebra

Projects

None yet

Development

Successfully merging this pull request may close these issues.

minimal_generating_set fails for ideals created by a f4 groebner basis

3 participants