Add a QQBar interface to GAP#4952
Merged
fingolfin merged 3 commits intooscar-system:masterfrom Jun 4, 2025
Merged
Conversation
ThomasBreuer
added
enhancement
fingolfin
reviewed
Jun 3, 2025
fingolfin
reviewed
Jun 3, 2025
fingolfin
reviewed
Jun 3, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4952 +/- ##
==========================================
- Coverage 84.88% 84.87% -0.01%
==========================================
Files 697 697
Lines 93925 93932 +7
==========================================
Hits 79725 79725
- Misses 14200 14207 +7
🚀 New features to boost your workflow:
|
- assign `QQBarFieldElementMatrixType` at load time - omit unnecessary `JuliaPointer` calls
- Do not use `Oscar_jl.eval`, it will result in error messages: ERROR: LoadError: InitError: Error thrown by GAP: Error, Evaluation into the closed module `Oscar` breaks incremental compilation because the side effects will not be permanent. This is likely due to some other module mutating `Oscar` with `eval` during precompilation - don't do this. - Instead, bind the constant in question in Oscar's Julia code. (For that, rename `gap/pkg/OscarInterface/julia/alnuth.jl` to `gap/pkg/OscarInterface/julia/constants.jl`, and rename the Julia module from `Alnuth` to `OscarInterfaceConstants`.
lgoettgens
referenced
this pull request
Sep 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(addresses issue #4948)
If we decide that the code should be inside the OscarInterface package then this is the occasion to start a package manual for OscarInterface.