Skip to content

Resolve hash error for FTM-1511-03209 artifact#4957

Merged
fingolfin merged 1 commit intooscar-system:masterfrom
emikelsons:FTMArtifact
Jun 4, 2025
Merged

Resolve hash error for FTM-1511-03209 artifact#4957
fingolfin merged 1 commit intooscar-system:masterfrom
emikelsons:FTMArtifact

Conversation

@emikelsons
Copy link
Copy Markdown
Collaborator

This is addressing #4956

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.87%. Comparing base (7f0c3c7) to head (2b745b6).
Report is 11 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4957   +/-   ##
=======================================
  Coverage   84.87%   84.87%           
=======================================
  Files         697      697           
  Lines       93932    93932           
=======================================
  Hits        79724    79724           
  Misses      14208    14208           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@benlorenz benlorenz added the extra-long Also run the extra-long tests during CI. label Jun 4, 2025
@lgoettgens lgoettgens added topic: FTheoryTools release notes: not needed PRs introducing changes that are wholly irrelevant to the release notes backport 1.4.x backport for release branch 1.4 labels Jun 4, 2025
@benlorenz
Copy link
Copy Markdown
Member

Thanks!
I have created #4959 to allow running the extra-long tests for PRs with the corresponding label. If we merge that one first and close+re-open this PR it should allow us to verify this and check the tests.

@benlorenz benlorenz closed this Jun 4, 2025
@benlorenz benlorenz reopened this Jun 4, 2025
@benlorenz benlorenz linked an issue Jun 4, 2025 that may be closed by this pull request
@benlorenz
Copy link
Copy Markdown
Member

The extra-long tests were successful but seem to be taking a bit longer than before. Previous runs on master were 60-70 minutes, this time it took 85 min. Not sure if this is expected with the updated date files.

@emikelsons
Copy link
Copy Markdown
Collaborator Author

I saw that the downloading of the FTM artifact failed once before it eventually worked

@benlorenz
Copy link
Copy Markdown
Member

I saw that the downloading of the FTM artifact failed once before it eventually worked

That is expected, julia first tries the pkgservers which mirror all artifacts that are referred to by released versions of packages. And if that fails it will try the original url.
So once there is an Oscar release with this artifact (with the correct hash) the download should work on the first attempt.

@fingolfin
Copy link
Copy Markdown
Member

Let's merge this. If it the performance regression is permanent we'll revisit this.

@fingolfin fingolfin merged commit 19c636e into oscar-system:master Jun 4, 2025
66 of 68 checks passed
benlorenz pushed a commit that referenced this pull request Jun 5, 2025
(cherry picked from commit 19c636e)
@benlorenz benlorenz mentioned this pull request Jun 5, 2025
4 tasks
@lgoettgens lgoettgens added release notes: use title For PRs: the title of this PR is suitable for direct use in the release notes and removed release notes: not needed PRs introducing changes that are wholly irrelevant to the release notes labels Jun 6, 2025
@benlorenz benlorenz removed the backport 1.4.x backport for release branch 1.4 label Jun 6, 2025
@lgoettgens lgoettgens added the backport 1.4.x done has been backported to release branch 1.4 label Jun 6, 2025
@emikelsons emikelsons deleted the FTMArtifact branch August 15, 2025 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport 1.4.x done has been backported to release branch 1.4 extra-long Also run the extra-long tests during CI. release notes: use title For PRs: the title of this PR is suitable for direct use in the release notes topic: FTheoryTools

Projects

None yet

Development

Successfully merging this pull request may close these issues.

FTM-1511-03209 artifact has wrong hash

4 participants