Add natural_gset method for permutation, matrix & Weyl groups#4987
Merged
lgoettgens merged 10 commits intooscar-system:masterfrom Jun 12, 2025
Merged
Add natural_gset method for permutation, matrix & Weyl groups#4987lgoettgens merged 10 commits intooscar-system:masterfrom
natural_gset method for permutation, matrix & Weyl groups#4987lgoettgens merged 10 commits intooscar-system:masterfrom
Conversation
jamesnohilly
added
the
release notes: use title
lgoettgens
reviewed
Jun 11, 2025
fingolfin
approved these changes
Jun 11, 2025
Member
fingolfin
left a comment
fingolfin
left a comment
There was a problem hiding this comment.
Looks good to me but I think @lgoettgens has some issues with infinite Weyl groups in this PR
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4987 +/- ##
==========================================
+ Coverage 84.87% 84.89% +0.01%
==========================================
Files 697 697
Lines 93901 93885 -16
==========================================
+ Hits 79699 79702 +3
+ Misses 14202 14183 -19
🚀 New features to boost your workflow:
|
lgoettgens
reviewed
Jun 12, 2025
lgoettgens
reviewed
Jun 12, 2025
This was referenced Jun 18, 2025
lgoettgens
referenced
this pull request
Sep 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements
natural_gsetfor permutation, matrix and Weyl groups for #4938.We deprecate
gset(::PermGroup)andgset(::MatrixGroup)and let it point towards the correspondingnatural_gset.