Deprecate vector_space_dimension, use vector_space_dim instead#5030
Merged
lgoettgens merged 1 commit intomasterfrom Jun 30, 2025
Merged
Deprecate vector_space_dimension, use vector_space_dim instead#5030lgoettgens merged 1 commit intomasterfrom
vector_space_dimension, use vector_space_dim instead#5030lgoettgens merged 1 commit intomasterfrom
Conversation
fingolfin
added
topic: commutative algebra
release notes: use title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5030 +/- ##
==========================================
- Coverage 84.86% 84.86% -0.01%
==========================================
Files 698 698
Lines 94290 94290
==========================================
- Hits 80022 80021 -1
- Misses 14268 14269 +1
🚀 New features to boost your workflow:
|
lgoettgens
approved these changes
Jun 30, 2025
Member
lgoettgens
left a comment
lgoettgens
left a comment
There was a problem hiding this comment.
LGTM, but maybe @afkafkafk13 or @HechtiDerLachs wanna have a look as well?
afkafkafk13
approved these changes
Jun 30, 2025
Collaborator
afkafkafk13
left a comment
afkafkafk13
left a comment
There was a problem hiding this comment.
You were just a few moments faster than me.... Looks good to me, too.
lgoettgens
referenced
this pull request
Sep 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See also PR #4967 (which will likely have minor conflicts with this), CC @emikelsons