Graduate "Quadratic forms and isometries" from experimental to officially supported#5046
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #5046 +/- ##
==========================================
- Coverage 84.86% 84.84% -0.03%
==========================================
Files 698 696 -2
Lines 94290 94320 +30
==========================================
Hits 80022 80022
- Misses 14268 14298 +30
🚀 New features to boost your workflow:
|
| include(joinpath(Oscar.oscardir, "test", "Serialization", "setup_tests.jl")) | ||
| include(joinpath(Oscar.oscardir, "test", "Serialization", "upgrades", "setup_tests.jl")) |
There was a problem hiding this comment.
you shouldn't need these lines here.
Does the error have to do with the upgrade script?
whats the error exactly?
There was a problem hiding this comment.
I think you need to move the serialization related tests from this file to test/Serialization/QuadForm.jl, and then you don't need these two lines anymore.
I did the same thing when moving root systems to src half a year ago, aka move all serialization tests to some file in the test/Serialization folder
There was a problem hiding this comment.
you shouldn't need these lines here. Does the error have to do with the upgrade script? whats the error exactly?
The errors I encountered are "test_save_load_roundtrip not defined" and same with "test_1_4_0_upgrade is not defined".
Following Lars' suggestion, I have moved the "test save roundtrip" tests inside the Serialization/QuadForm.jl test file, and for the upgrade test, I have removed ZZLatWithIsom from the exclude list in file Serialization/upgrades/runtests (last line). See the upcoming commit
There was a problem hiding this comment.
Yeah, looks good like this. Let's wait for CI to agree
lgoettgens
changed the title
QuadFormAndIsom to source
lgoettgens
changed the title
lgoettgens
added
the
release notes: use title
4 participants
Close #4796.
Move the project
QuadFormAndIsomfromexperimentaltosrc/NumberTheory.At the same time, in order to have consistency within the documentation, I have moved the chapter on "Quadratic and Hermitian forms" to under "Number Theory" of the manual (it is currently under "Linear Algebra").
I have merged the old
experimental/QuadFormAndIsom/src/serialization.jlwith the existing filesrc/Serialization/QuadForm.jl.@antonydellavecchia I had a problem with the function
test_save_load_roundtripwhile running the tests locally, so I moved the content ofexperimental/QuadFormAndIsom/test/setup_tests.jlat the beginning oftest/NumberTheory/QuadFormAndIsom.jl. Is it OK like this or is there another way ?