Use Laurent polynomial ring approach to speed up computation of toric_ideal#5073
Merged
HereAround merged 3 commits intomasterfrom Jul 7, 2025
Merged
Use Laurent polynomial ring approach to speed up computation of toric_ideal#5073HereAround merged 3 commits intomasterfrom
toric_ideal#5073HereAround merged 3 commits intomasterfrom
Conversation
lkastner
added
enhancement
benlorenz
reviewed
Jul 4, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5073 +/- ##
==========================================
- Coverage 84.90% 84.90% -0.01%
==========================================
Files 706 706
Lines 95430 95436 +6
==========================================
+ Hits 81026 81030 +4
- Misses 14404 14406 +2
🚀 New features to boost your workflow:
|
fingolfin
changed the title
toric_ideal
fingolfin
added
the
release notes: use title
lgoettgens
reviewed
Jul 7, 2025
…c_ideal.jl Co-authored-by: Lars Göttgens <lars.goettgens@rwth-aachen.de>
fingolfin
reviewed
Jul 7, 2025
…c_ideal.jl Co-authored-by: Max Horn <max@quendi.de>
HereAround
approved these changes
Jul 7, 2025
Member
HereAround
left a comment
HereAround
left a comment
There was a problem hiding this comment.
Thank you @lkastner for the quick fix. Looks good to me.
lgoettgens
referenced
this pull request
Sep 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4685