Skip to content

Support kernel of maps with Laurent polynomials as codomain#5078

Merged
thofma merged 1 commit intomasterfrom
th/laurent
Jul 6, 2025
Merged

Support kernel of maps with Laurent polynomials as codomain#5078
thofma merged 1 commit intomasterfrom
th/laurent

Conversation

@thofma
Copy link
Copy Markdown
Collaborator

@thofma thofma commented Jul 5, 2025

@lkastner this allows:

julia> Hmat = matrix(ZZ, H)
[ 1   0]
[ 0   1]
[-2   5]
[-1   3]

julia> R,_ = polynomial_ring(QQ,nrows(Hmat));

julia> S,x = laurent_polynomial_ring(QQ, ncols(Hmat));

julia> f = hom(R, S, [prod(x.^Hmat[i,:]) for i in (1:nrows(Hmat))])
Ring homomorphism
  from multivariate polynomial ring in 4 variables over QQ
  to multivariate Laurent polynomial ring in 2 variables over QQ
defined by
  x1 -> x1
  x2 -> x2
  x3 -> x1^-2*x2^5
  x4 -> x1^-1*x2^3

julia> kernel(f)
Ideal generated by
  x2*x3 - x4^2
  -x1*x3 + x2^2*x4
  -x1*x4 + x2^3
  -x1*x3^2 + x2*x4^3
  -x1*x3^3 + x4^5

@thofma thofma requested a review from HechtiDerLachs July 5, 2025 20:08
Copy link
Copy Markdown
Member

@lkastner lkastner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Geil, danke!

@thofma thofma added the release notes: use title For PRs: the title of this PR is suitable for direct use in the release notes label Jul 5, 2025
@thofma thofma changed the title feat: support kernel of maps with Laurent polynomials as codomain Support kernel of maps with Laurent polynomials as codomain Jul 5, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.90%. Comparing base (b1aab33) to head (6b78415).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5078   +/-   ##
=======================================
  Coverage   84.90%   84.90%           
=======================================
  Files         706      706           
  Lines       95421    95424    +3     
=======================================
+ Hits        81017    81022    +5     
+ Misses      14404    14402    -2     
Files with missing lines Coverage Δ
src/Rings/MPolyMap/AffineAlgebras.jl 96.69% <100.00%> (+0.08%) ⬆️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@thofma thofma enabled auto-merge (squash) July 6, 2025 08:31
@thofma thofma merged commit 40772af into master Jul 6, 2025
34 of 35 checks passed
@thofma thofma deleted the th/laurent branch July 6, 2025 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request release notes: use title For PRs: the title of this PR is suitable for direct use in the release notes topic: commutative algebra

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants