Skip to content

Fix a bug in galois_group that resulted in too small groups being returned#5109

Merged
thofma merged 1 commit intomasterfrom
CF/fagu_galois
Jul 15, 2025
Merged

Fix a bug in galois_group that resulted in too small groups being returned#5109
thofma merged 1 commit intomasterfrom
CF/fagu_galois

Conversation

@fieker
Copy link
Copy Markdown
Contributor

@fieker fieker commented Jul 15, 2025

should fix #5108

@lgoettgens lgoettgens changed the title bug in galois groups Fix a bug in galois_group that resulted in too small groups being returned Jul 15, 2025
@lgoettgens lgoettgens added topic: number theory release notes: use title For PRs: the title of this PR is suitable for direct use in the release notes labels Jul 15, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 15, 2025

Codecov Report

Attention: Patch coverage is 92.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 84.90%. Comparing base (dc9db0c) to head (e6579c3).
Report is 26 commits behind head on master.

Files with missing lines Patch % Lines
src/NumberTheory/GaloisGrp/GaloisGrp.jl 92.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           master    #5109    +/-   ##
========================================
  Coverage   84.90%   84.90%            
========================================
  Files         706      706            
  Lines       95437    95621   +184     
========================================
+ Hits        81030    81187   +157     
- Misses      14407    14434    +27     
Files with missing lines Coverage Δ
src/NumberTheory/GaloisGrp/GaloisGrp.jl 79.81% <92.00%> (+0.01%) ⬆️

... and 47 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@thofma thofma merged commit b9121b9 into master Jul 15, 2025
34 of 38 checks passed
@thofma thofma deleted the CF/fagu_galois branch July 15, 2025 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug: wrong result release notes: use title For PRs: the title of this PR is suitable for direct use in the release notes topic: number theory

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Wrong Galois group (or splitting field)

3 participants