Add isinteger, is_rational and is_integral for QQAbFieldElem#5126
Add isinteger, is_rational and is_integral for QQAbFieldElem#5126fingolfin merged 3 commits intooscar-system:masterfrom
isinteger, is_rational and is_integral for QQAbFieldElem#5126Conversation
joschmitt
added
release notes: use title
Co-authored-by: Johannes Schmitt <jschmitt@posteo.eu>
|
@SoongNoonien could you already adapt the Hecke compat bound in the |
| @doc raw""" | ||
| isinteger(a::QQAbFieldElem) | ||
|
|
||
| Return whether $a$ is an integer. | ||
| """ |
There was a problem hiding this comment.
Should we really add this kind of docstring? Isn't this already covered by the Julia's primary docstring for isinteger? In fact looking at the output of ?isinteger in the REPL I think we could basically remove all of them.
There was a problem hiding this comment.
Yes, I think we need some concerned effort to remove some redundant docstrings (I am also one of the offenders). It is easier now since we can include docstrings multiple times in the documentation.
There was a problem hiding this comment.
Fair enough. I am probably as well. And some of them are not trivial to remove because e.g. the Nemo doc includes several of them (but I think in all cases this could be avoided by inserting some general text like "For this ring the following things are implemented: +, -, isinteger, "
Anyway, no reason to hold up this PR I think.
|
If JuliaRegistries/General#134995 is merged, someone can open/close this PR here. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5126 +/- ##
=======================================
Coverage 84.90% 84.91%
=======================================
Files 706 706
Lines 95627 95631 +4
=======================================
+ Hits 81191 81201 +10
+ Misses 14436 14430 -6
🚀 New features to boost your workflow:
|
5 participants
This depends on thofma/Hecke.jl#1923 and thofma/Hecke.jl#1922.
fixes #5096