Add OscarDB to experimental#5137
Conversation
Co-authored-by: Lars Göttgens <lars.goettgens@rwth-aachen.de>
… into adv/matrix-groups-serialization
… into adv+ak/leech-pair-collection
fingolfin
left a comment
fingolfin
left a comment
There was a problem hiding this comment.
Just some quick comments. I clearly lack information about the context of this, and I also realize this is marked as draft. As such, some of my comments may be "too nitty-gritty"; feel free to ignore them; I simply marked stuff I noticed while I read through the entire PR, as I figure @antonydellavecchia is capable of dealing with it (i.e. taking what he need and ignoring the rest for now)
antonydellavecchia
changed the title
antonydellavecchia
added
OscarDB
release notes: use title
…m/Oscar.jl into adv+ak/leech-pair-collection
|
@StevellM I created a stub for the documentation for the collection of Leech pairs in the introduction.md Please check and add a sentence or two. Afterwards this PR is ready for merge. (see the ping in the changed files section) |
|
|
||
| See also [Lut08](@cite). | ||
|
|
||
| ### Leech pairs |
There was a problem hiding this comment.
@StevellM expanding on this specifically, thanks!
micjoswig
left a comment
micjoswig
left a comment
There was a problem hiding this comment.
Oscar DB seems to work; documentation was expanded; good to go for now.
@fingolfin concerning the doctest failure MacOS / RPTU, could this be a network issue at RPTU?
benlorenz
left a comment
benlorenz
left a comment
There was a problem hiding this comment.
Regarding the test failures, we should probably not (doc-)test against the live database. This will avoid issues on the rptu runner.
We might look into adding some workaround for JuliaDatabases/Mongoc.jl#124, there was such a crash on teardown in the 1.12 run.
|
|
||
| In this case we find the unique six-vertex triangulation of the real projective plane. | ||
|
|
||
| ```jldoctest |
There was a problem hiding this comment.
we try to avoid testing against the live database, to avoid network issues, we could change it to julia-repl like the other examples in this file.
| ```jldoctest | |
| ```julia-repl |
Would be nice if there was a way to conditionally skip some doctests, and then run them explicitly via Oscar.doctest(functionname) in the jobs that have the testing database container running (after making sure that example is present).
Co-authored-by: Benjamin Lorenz <benlorenz@users.noreply.github.com>
7 participants
First merge for code for OscarDB
The following two collections are currently loadable from oscar-dev
LeechPairs in database.
VertexTransitiveSimplicialComplexes (manifolds from dimension 2 to 11 from https://www3.math.tu-berlin.de/IfM/Nachrufe/Frank_Lutz/stellar/vertex-transitive-triangulations.html)
Still need oscar-dev user for tests (or find a solution for testing)