Skip to content

Add smallest_moved_point and largest_moved_point#5140

Merged
lgoettgens merged 2 commits intomasterfrom
mh/moved_points
Jul 19, 2025
Merged

Add smallest_moved_point and largest_moved_point#5140
lgoettgens merged 2 commits intomasterfrom
mh/moved_points

Conversation

@fingolfin
Copy link
Copy Markdown
Member

Also add them plus existing (number_)moved_points into the manual.

@fingolfin fingolfin requested a review from ThomasBreuer July 18, 2025 20:49
@fingolfin fingolfin added topic: groups enhancement New feature or request release notes: use title For PRs: the title of this PR is suitable for direct use in the release notes labels Jul 18, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.91%. Comparing base (16ac0fb) to head (9e4be49).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5140      +/-   ##
==========================================
+ Coverage   84.61%   84.91%   +0.29%     
==========================================
  Files         706      706              
  Lines       95579    95606      +27     
==========================================
+ Hits        80877    81184     +307     
+ Misses      14702    14422     -280     
Files with missing lines Coverage Δ
src/GAP/wrappers.jl 95.49% <100.00%> (+0.01%) ⬆️
src/Groups/perm.jl 96.09% <100.00%> (+0.09%) ⬆️

... and 30 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Member

@ThomasBreuer ThomasBreuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just two comments

Comment thread src/Groups/perm.jl Outdated
Comment thread src/Groups/perm.jl Outdated
Co-authored-by: Thomas Breuer <sam@math.rwth-aachen.de>
@lgoettgens lgoettgens merged commit 22f9844 into master Jul 19, 2025
33 of 34 checks passed
@lgoettgens lgoettgens deleted the mh/moved_points branch July 19, 2025 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request release notes: use title For PRs: the title of this PR is suitable for direct use in the release notes topic: groups

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants