Skip to content

Fix a bug in the computation of matroid realization spaces with saturated defining ideal#5182

Merged
joschmitt merged 2 commits intooscar-system:masterfrom
LukasKuehne:master
Aug 18, 2025
Merged

Fix a bug in the computation of matroid realization spaces with saturated defining ideal#5182
joschmitt merged 2 commits intooscar-system:masterfrom
LukasKuehne:master

Conversation

@LukasKuehne
Copy link
Copy Markdown
Contributor

Thanks to @danteluber for finding this issue.

@lgoettgens lgoettgens added the experimental Only changes experimental parts of the code label Aug 13, 2025
@lgoettgens
Copy link
Copy Markdown
Member

Thanks for the PR!
Did this result in a crash or wrong result when called before this change? Could you (if possible) add some test that used to fail but now succeeds?

@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 13, 2025

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 84.84%. Comparing base (7f7a868) to head (dc5961b).

Files with missing lines Patch % Lines
.../MatroidRealizationSpaces/src/realization_space.jl 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5182   +/-   ##
=======================================
  Coverage   84.84%   84.84%           
=======================================
  Files         710      710           
  Lines       95517    95517           
=======================================
  Hits        81045    81045           
  Misses      14472    14472           
Files with missing lines Coverage Δ
.../MatroidRealizationSpaces/src/realization_space.jl 90.50% <0.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@LukasKuehne
Copy link
Copy Markdown
Contributor Author

Thanks for the PR! Did this result in a crash or wrong result when called before this change? Could you (if possible) add some test that used to fail but now succeeds?

It crashed before. I added a test with the matroid where this occurred which now works.

@joschmitt joschmitt added topic: combinatorics release notes: use title For PRs: the title of this PR is suitable for direct use in the release notes bug: wrong result labels Aug 18, 2025
@joschmitt joschmitt changed the title Fixed a small bug in the matroid realization space code Fix a bug in the computation of matroid realization spaces with saturated defining ideal Aug 18, 2025
Copy link
Copy Markdown
Member

@joschmitt joschmitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

I cannot judge the mathematics, but the changes look reasonable.

@joschmitt joschmitt enabled auto-merge (squash) August 18, 2025 08:48
@joschmitt joschmitt merged commit 873e142 into oscar-system:master Aug 18, 2025
52 of 58 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug: wrong result experimental Only changes experimental parts of the code release notes: use title For PRs: the title of this PR is suitable for direct use in the release notes topic: combinatorics

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants