n_cones and cones now properly consider all cones

[benlorenz]

With a keyword argument to suppress the trivial cone.

This is slightly breaking but I consider this a bugfix:

The original docstring for cones claimed

Return the ray indices of all non-zero-dimensional cones in a polyhedral fan.

which was not true since it always excluded the minimal cone even when it has a non-empty lineality space (and thus positive dimension).

For ncones:

Return the number of cones of PF.

But this also excluded the trivial cone.

Closes #4815

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.84%. Comparing base (57b958d) to head (128b24f).
⚠️ Report is 9 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #5217      +/-   ##
==========================================
- Coverage   84.84%   84.84%   -0.01%     
==========================================
  Files         710      710              
  Lines       95637    95651      +14     
==========================================
+ Hits        81145    81156      +11     
- Misses      14492    14495       +3     

Files with missing lines	Coverage Δ
...try/ToricVarieties/AlgebraicCycles/constructors.jl	86.31% <100.00%> (ø)
...ricVarieties/AlgebraicCycles/special_attributes.jl	100.00% <100.00%> (ø)
src/PolyhedralGeometry/PolyhedralFan/properties.jl	98.50% <100.00%> (+0.02%)	⬆️

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.