Skip to content

Update to GAP.jl 0.15#5226

Merged
fingolfin merged 4 commits intomasterfrom
lg/adapt-GAP.jl-0.14
Sep 3, 2025
Merged

Update to GAP.jl 0.15#5226
fingolfin merged 4 commits intomasterfrom
lg/adapt-GAP.jl-0.14

Conversation

@lgoettgens
Copy link
Copy Markdown
Member

@lgoettgens lgoettgens commented Aug 21, 2025 •
edited
Loading

This PR is mainly here to allow us to run downstream CI from the GAP.jl repo.

cc @fingolfin @ThomasBreuer

@lgoettgens
Adapt to NemoExt in GAP (#5139)
6d25a37 
* Drop GAP<->Nemo conversions that moved to GAP's NemoExt

* Re-add helper

* Remove tests that moved to GAP.jl
@lgoettgens lgoettgens added package: GAP WIP NOT ready for merging labels Aug 21, 2025
@lgoettgens lgoettgens marked this pull request as draft August 21, 2025 09:18
@lgoettgens lgoettgens changed the title Adapt to GAP.jl 0.14 Adapt to GAP.jl 0.15 Aug 21, 2025
@lgoettgens lgoettgens mentioned this pull request Aug 21, 2025
Closed
@lgoettgens lgoettgens mentioned this pull request Aug 25, 2025
Closed
16 tasks
@lgoettgens lgoettgens changed the title Adapt to GAP.jl 0.15 Update to GAP.jl 0.15 Aug 26, 2025
@lgoettgens lgoettgens added release notes: use title For PRs: the title of this PR is suitable for direct use in the release notes needs hecke update and removed WIP NOT ready for merging labels Aug 26, 2025
@lgoettgens lgoettgens closed this Aug 26, 2025
@lgoettgens lgoettgens reopened this Aug 26, 2025
@lgoettgens lgoettgens marked this pull request as ready for review August 26, 2025 15:48
@lgoettgens
Copy link
Copy Markdown
Member Author

lgoettgens commented Sep 1, 2025

Bump @ThomasBreuer @fingolfin

@lgoettgens lgoettgens closed this Sep 2, 2025
@lgoettgens lgoettgens reopened this Sep 2, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 2, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 84.97%. Comparing base (cc27a3d) to head (2a0d2d1).
⚠️ Report is 21 commits behind head on master.

Files with missing lines Patch % Lines
src/GAP/gap_to_oscar.jl 66.66% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #5226      +/-   ##
==========================================
+ Coverage   84.86%   84.97%   +0.10%     
==========================================
  Files         708      713       +5     
  Lines       95623    96879    +1256     
==========================================
+ Hits        81149    82320    +1171     
- Misses      14474    14559      +85
Files with missing lines Coverage Δ
src/GAP/oscar_to_gap.jl 100.00% <ø> (+4.00%) ⬆️
src/GAP/gap_to_oscar.jl 96.42% <66.66%> (+0.97%) ⬆️

... and 23 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

fingolfin
fingolfin approved these changes Sep 3, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@fingolfin fingolfin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@fingolfin fingolfin merged commit 1738e00 into master Sep 3, 2025
69 of 99 checks passed
@fingolfin fingolfin deleted the lg/adapt-GAP.jl-0.14 branch September 3, 2025 10:31
SirToby25 pushed a commit to SirToby25/Oscar.jl that referenced this pull request Sep 5, 2025
@lgoettgens @SirToby25
Update to GAP.jl 0.15 (oscar-system#5226)
01e8ae7
lgoettgens referenced this pull request Sep 11, 2025
@lgoettgens
Merge pull request #5296 from oscar-system/lg/version-1.5
f466410
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fingolfin fingolfin fingolfin approved these changes

@ThomasBreuer ThomasBreuer Awaiting requested review from ThomasBreuer

Assignees

No one assigned

Labels

package: GAP release notes: use title For PRs: the title of this PR is suitable for direct use in the release notes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lgoettgens @fingolfin