Skip to content

[FTheoryTools] Minor improvement#5263

Merged
HereAround merged 1 commit intooscar-system:masterfrom
HereAround:MinorTweakFTheoryTools
Sep 2, 2025
Merged

[FTheoryTools] Minor improvement#5263
HereAround merged 1 commit intooscar-system:masterfrom
HereAround:MinorTweakFTheoryTools

Conversation

@HereAround
Copy link
Copy Markdown
Member

Follow-up to #5214.

We do not need consistency_checks for this G4-flux constructor, as this one uses a family of well-quantized fluxes that pass the transversality constraints. So the result will always come back as true...

cc @apturner @emikelsons

@HereAround HereAround marked this pull request as ready for review September 2, 2025 16:07
@HereAround HereAround added release notes: not needed PRs introducing changes that are wholly irrelevant to the release notes topic: FTheoryTools optimization Simpler/more performant code or more/better tests labels Sep 2, 2025
Copy link
Copy Markdown
Collaborator

@emikelsons emikelsons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and the change is small!

@HereAround HereAround enabled auto-merge (rebase) September 2, 2025 16:13
@HereAround HereAround added the extra-long Also run the extra-long tests during CI. label Sep 2, 2025
@HereAround HereAround closed this Sep 2, 2025
auto-merge was automatically disabled September 2, 2025 18:44

Pull request was closed

@HereAround HereAround reopened this Sep 2, 2025
@HereAround HereAround enabled auto-merge (rebase) September 2, 2025 18:44
@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 2, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.91%. Comparing base (94de420) to head (9bf8613).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5263   +/-   ##
=======================================
  Coverage   84.91%   84.91%           
=======================================
  Files         713      713           
  Lines       96410    96410           
=======================================
  Hits        81865    81865           
  Misses      14545    14545           
Files with missing lines Coverage Δ
...ental/FTheoryTools/src/FamilyOfG4Fluxes/methods.jl 97.10% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@HereAround HereAround merged commit 3c6583c into oscar-system:master Sep 2, 2025
76 of 92 checks passed
@HereAround HereAround deleted the MinorTweakFTheoryTools branch September 2, 2025 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

extra-long Also run the extra-long tests during CI. optimization Simpler/more performant code or more/better tests release notes: not needed PRs introducing changes that are wholly irrelevant to the release notes topic: FTheoryTools

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants