Implement chamber counting algorithm for toric line bundles#5284
Merged
HereAround merged 1 commit intooscar-system:masterfrom Sep 10, 2025
Merged
Implement chamber counting algorithm for toric line bundles#5284HereAround merged 1 commit intooscar-system:masterfrom
HereAround merged 1 commit intooscar-system:masterfrom
Conversation
emikelsons
added
release notes: use title
HereAround
approved these changes
Sep 10, 2025
Member
HereAround
left a comment
HereAround
left a comment
There was a problem hiding this comment.
Thank you for the long and hard work on this @emikelsons . LGTM!
HereAround
added
release notes: to be added
lgoettgens
referenced
this pull request
Sep 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement the chamber counting algorithm for calculating cohomologies of toric line bundles. This is essentially a squashed version of #5119 reopened by me per the suggestion of @HereAround.