Reduce yet more randomness in FTheoryTools#5295
Merged
HereAround merged 5 commits intooscar-system:masterfrom Sep 12, 2025
Merged
Reduce yet more randomness in FTheoryTools#5295HereAround merged 5 commits intooscar-system:masterfrom
HereAround merged 5 commits intooscar-system:masterfrom
Conversation
emikelsons
approved these changes
Sep 10, 2025
Collaborator
emikelsons
left a comment
There was a problem hiding this comment.
Looks good and the tests pass!
Collaborator
|
I didn't notice the comment at first, but it makes sense that |
9155107 to
9697615
Compare
Member
Author
Alright. I will come back to those issues/open ends in the next PR. |
Member
|
I've now changed this to use the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
g4_flux_family(gf::G4Flux; completeness_check::Bool = true)be changed? I suppose it should allow to switch the algorithm used to create the g4 flux family by? If so, likely (?) also needs an rng kwarg.cc @emikelsons @apturner