Skip to content

Allow to specify several characteristic polynomials in lattice with isometry enumeration#5457

Merged
simonbrandhorst merged 13 commits intomasterfrom
sb/isometry_enum_with_list
Oct 20, 2025
Merged

Allow to specify several characteristic polynomials in lattice with isometry enumeration#5457
simonbrandhorst merged 13 commits intomasterfrom
sb/isometry_enum_with_list

Conversation

@simonbrandhorst
Copy link
Copy Markdown
Collaborator

  • Allow lists of characteristic or minimal polynomials in enumerate_classes_of_lattices_with_isometry
  • disable expensive check

@simonbrandhorst simonbrandhorst added the release notes: use title For PRs: the title of this PR is suitable for direct use in the release notes label Oct 15, 2025
Copy link
Copy Markdown
Member

@StevellM StevellM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, that is something good to have. However, I am not completely happy with the interface. Since it only touches keyword arguments, I would be in favour to remove the previous interface and just keep lists of "bla" instead of accumulating keyword arguments. You did it in some places, in other places you added extra shortcut functions to fit with the previous interface and in other places you completely removed the previous interface. Which is not consistent. I think we could just replace the previous interface to give lists of eiglat_cond, char_poly and min_poly. I could live with adding brackets in my code where needed. If you think we should still support the previous interface, then we should probably add aliases that transform standalone keyword arguments into lists of one element.

Comment thread src/NumberTheory/QuadFormAndIsom/enumeration.jl Outdated
Comment thread src/NumberTheory/QuadFormAndIsom/enumeration.jl Outdated
Comment thread src/NumberTheory/QuadFormAndIsom/enumeration.jl Outdated
Comment thread src/NumberTheory/QuadFormAndIsom/enumeration.jl Outdated
Comment thread src/NumberTheory/QuadFormAndIsom/enumeration.jl Outdated
Comment thread src/NumberTheory/QuadFormAndIsom/enumeration.jl Outdated
Comment thread src/NumberTheory/QuadFormAndIsom/enumeration.jl
Comment thread src/NumberTheory/QuadFormAndIsom/enumeration.jl Outdated
Comment thread src/NumberTheory/QuadFormAndIsom/enumeration.jl
Comment thread src/NumberTheory/QuadFormAndIsom/enumeration.jl
@StevellM
Copy link
Copy Markdown
Member

We talked about, at some point. to change conditions on rank and signature by ranges or lists instead of single integers. Does having lists of triples a good enough solution or should we think about extending the interface to that, up to modify admissible_triples and related functions accordingly ?

simonbrandhorst and others added 6 commits October 16, 2025 11:17
Co-authored-by: Stevell Muller <78619134+StevellM@users.noreply.github.com>
Co-authored-by: Stevell Muller <78619134+StevellM@users.noreply.github.com>
Co-authored-by: Stevell Muller <78619134+StevellM@users.noreply.github.com>
Co-authored-by: Stevell Muller <78619134+StevellM@users.noreply.github.com>
Co-authored-by: Stevell Muller <78619134+StevellM@users.noreply.github.com>
Co-authored-by: Stevell Muller <78619134+StevellM@users.noreply.github.com>
Comment thread src/NumberTheory/QuadFormAndIsom/enumeration.jl Outdated
@simonbrandhorst
Copy link
Copy Markdown
Collaborator Author

I just needed to write something that is backwards compatible. I am OK with deprecating the old interface.
But I think that in the long run we need an object the curates all conditions one may want to impose and
checks for consistency etc.

@simonbrandhorst simonbrandhorst merged commit 50c1ddf into master Oct 20, 2025
48 of 64 checks passed
@simonbrandhorst simonbrandhorst deleted the sb/isometry_enum_with_list branch October 20, 2025 14:29
@lgoettgens lgoettgens added the enhancement New feature or request label Nov 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request release notes: use title For PRs: the title of this PR is suitable for direct use in the release notes topic: number theory

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants