Allow to specify several characteristic polynomials in lattice with isometry enumeration#5457
Conversation
simonbrandhorst
commented
Oct 15, 2025
- Allow lists of characteristic or minimal polynomials in enumerate_classes_of_lattices_with_isometry
- disable expensive check
…sses_of_lattices_with_isometry
StevellM
left a comment
There was a problem hiding this comment.
Thanks, that is something good to have. However, I am not completely happy with the interface. Since it only touches keyword arguments, I would be in favour to remove the previous interface and just keep lists of "bla" instead of accumulating keyword arguments. You did it in some places, in other places you added extra shortcut functions to fit with the previous interface and in other places you completely removed the previous interface. Which is not consistent. I think we could just replace the previous interface to give lists of eiglat_cond, char_poly and min_poly. I could live with adding brackets in my code where needed. If you think we should still support the previous interface, then we should probably add aliases that transform standalone keyword arguments into lists of one element.
|
We talked about, at some point. to change conditions on rank and signature by ranges or lists instead of single integers. Does having lists of triples a good enough solution or should we think about extending the interface to that, up to modify |
Co-authored-by: Stevell Muller <78619134+StevellM@users.noreply.github.com>
Co-authored-by: Stevell Muller <78619134+StevellM@users.noreply.github.com>
Co-authored-by: Stevell Muller <78619134+StevellM@users.noreply.github.com>
Co-authored-by: Stevell Muller <78619134+StevellM@users.noreply.github.com>
Co-authored-by: Stevell Muller <78619134+StevellM@users.noreply.github.com>
Co-authored-by: Stevell Muller <78619134+StevellM@users.noreply.github.com>
|
I just needed to write something that is backwards compatible. I am OK with deprecating the old interface. |