Add multicombinations to Oscar#5477
Merged
fingolfin merged 10 commits intooscar-system:masterfrom Nov 5, 2025
Merged
Conversation
Member
|
Could you also please remove the implementation in Experimental/LieAlgebras and redirect all call-sites to this new implementation? |
3b804e6 to
9ea1b38
Compare
Member
|
This should be hooked up into the manual, too! We can of course merge this now and do that in a follow-up PR, but ideally that should come soon so we don't forget about it. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5477 +/- ##
==========================================
+ Coverage 84.05% 84.19% +0.13%
==========================================
Files 730 731 +1
Lines 99233 101201 +1968
==========================================
+ Hits 83412 85206 +1794
- Misses 15821 15995 +174
🚀 New features to boost your workflow:
|
lgoettgens
reviewed
Oct 29, 2025
Co-authored-by: Lars Göttgens <lars.goettgens@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The UI directly mirrors that of
combinations, the only difference being that we get combinations with repetitions allowed.At the moment I still need to add some tests and include documentation in the Oscar manual. But we see a nice speedup compared to the version in
Experimental/LieAlgebras(which to be fair was never claiming to be optimized at all).