Support optional "inplace" iteration for combinations and multicombinations#5530
Conversation
|
So if I understand correctly, the "inplace" kwarg only exists for the case of Could you add the new kwarg to the two respective docstrings? |
I don't believe it makes sense, or at the very least would not be possible without more extensive changes; I would have to think about how to accomplish this, we don't get it for "free" from the Do we want the kwarg in the docstrings? |
Two good points, then better leave it like it is (at least for now). But could you please add a test that makes use of the new kwarg? |
Co-authored-by: Lars Göttgens <lars.goettgens@gmail.com>
Co-authored-by: Max Horn <max@quendi.de>
|
As long as all the tests still pass after my most recent change, I think this is ready to merge; I will open an issue to bring up the discussion of |
For use cases that benefit, we provide an option to have inplace versions of the iterators for
combinations(n,k)andmulticombinations(n,k)using an optionalinplacekeyword.Closes #4993