Update changelog by github-actions[bot] · Pull Request #5544 · oscar-system/Oscar.jl

github-actions · 2025-11-12T11:16:57Z

Automated changes by create-pull-request GitHub action

lgoettgens · 2025-11-12T11:35:10Z

+### Tropical Geometry
+
+### Changes related to the package GAP
+
+### Changes related to the package Hecke
+
+### Changes related to the package Singular


why are there empty headers here without any content?

This happens when a PR was tagged with a topic label, but not with a type label. The script finds non zero number of things under tropical geometry, so generates a heading for it. But it never finds a type label, so, neither the secondary heading, nor the PR itself is printed here. They end up in the TODO section. IMO, leaving it like this might be fine, so, we know where to (manually) insert something.

I'd say it's better then to move these things with "missing labels into the right topic section, but in subsection #### TODO: missing type label or so

lgoettgens · 2025-11-12T11:36:07Z

+
+- [#5267](https://github.com/oscar-system/Oscar.jl/pull/5267) Add `order_bound` keyword argument to `subgroup_classes`
+- [#5284](https://github.com/oscar-system/Oscar.jl/pull/5284) Implement chamber counting algorithm for toric line bundles
+- [#5288](https://github.com/oscar-system/Oscar.jl/pull/5288) Add `p_rump` for `GAPGroup` and extend `torsion_subgroup` for `GAPGroup` and `WeylGroup`


This has a "topic: groups" label, but is not sorted into the appropriate section above

This should be fixed whenever #5279 is merged

Maybe it was unwise to add patches for this into that PR, from a keeping PRs on topic point of view, but its currently probably the fastest way of patching this.

joschmitt · 2025-11-12T12:04:07Z

Looking at some of the entries in the "TODO" categories, I realize that I don't know how many or what labels a pull request needs to make the script happy.
My impression is:

A release notes: ... label
A topic: ... label
Some other label like enhancement but I don't know what exactly falls into this category.

Is this correct? Is it written down somewhere? I so far I followed the two-label-approach from https://docs.oscar-system.org/stable/DeveloperDocumentation/changelog/ but apparently that's not enough anymore?

lgoettgens · 2025-11-12T12:19:57Z

Looking at some of the entries in the "TODO" categories, I realize that I don't know how many or what labels a pull request needs to make the script happy. My impression is:

A release notes: ... label

A topic: ... label

Some other label like enhancement but I don't know what exactly falls into this category.

Is this correct? Is it written down somewhere? I so far I followed the two-label-approach from https://docs.oscar-system.org/stable/DeveloperDocumentation/changelog/ but apparently that's not enough anymore?

As I noted in #5544 (comment), there is currently some issue with how these things are put into categories. I would assume that this also affects your examples

aaruni96 · 2025-11-12T21:31:58Z

apparently that's not enough anymore?

Your impression should be correct. Can you look at the new changelog ( 06019bf ), and if there is still unexpected behaviour, point out the exact PRs which are miscategorised ?

Some other label like enhancement but I don't know what exactly falls into this category.

The two kinds of labels (topics, and types) have been expanded upon, but this is still in the dev docs, not yet in stable.

https://docs.oscar-system.org/dev/DeveloperDocumentation/changelog/#Multi-level-topics

lgoettgens · 2025-11-12T22:04:21Z

+
+### **TODO** insufficient labels for automatic classification
+
+The following PRs only have a topic label assigned to them, not a PR type. Either assign a type label to them (e.g., `enhancement`), or manually move them to the general section of the topic section in the changelog.


Can you instead put the into their respective general section, but with a todo note each? I think it is easier to just manually remove todo notes than moving things around in this file.
I am asking because I see a bunch of things here, that don't fit into any subsection, e.g. updates of dependencies

Day's event have started. I shall look at it again today at night.

joschmitt · 2025-11-13T09:06:14Z

apparently that's not enough anymore?

Your impression should be correct. Can you look at the new changelog ( 06019bf ), and if there is still unexpected behaviour, point out the exact PRs which are miscategorised ?

Some other label like enhancement but I don't know what exactly falls into this category.

The two kinds of labels (topics, and types) have been expanded upon, but this is still in the dev docs, not yet in stable.

https://docs.oscar-system.org/dev/DeveloperDocumentation/changelog/#Multi-level-topics

Okay, sorry, I did not look at the most recent documentation. So the gist is that every pull request now needs three labels? And wouldn't it be good to have all the "type" labels start with "type:" and possibly all have the same colour?

fingolfin · 2025-11-13T14:17:49Z

Okay, sorry, I did not look at the most recent documentation. So the gist is that every pull request now needs three labels?

Yes that's how it has been since we introduced this system. (Well, you can get away with one label if it is release notes: not needed ;-) but in general: three)

And wouldn't it be good to have all the "type" labels start with "type:" and possibly all have the same colour?

I don't want this for the colors: both "bug" and "enhancement" are types, but one is red and the other not, and I'd like to stay it that way.

Wouldn't mind for them to share a common prefix, though. But perhaps we can not use "type" but rather something else, like "kind" or "category" -- the word "type" already is used heavily in our code and I'd like to avoid yet another overload of the meaning.

Regarding the topics, note that they have either prefix topic: or package:. But I think that's manageable. Then there is release notes: highlight which is a bit of an odd one; and so I also kinda think it is OK to leave it like that. It is really meant in addition to whatever other labels you have, to mark select PRs / new features that we want to highlight.

fingolfin · 2025-11-26T15:13:03Z

+
+Ping @HereAround , @friedemann2.
+
+~~Note: I can not test this version locally at the moment because with the latest master branch in Oscar.jl my julia is complaining about an incompatibility with GAP and I can somehow not resolve this issue with the usual updating procedures. I plan to clean this branch up a little further, once it works on my machine again.~~ Had to throw away my `~/.julia` folder; now it seems to work. Still working on the updates, though.
+


Tried using the release notes: use body label on #5512 but this did not work as I expected... ping @aaruni96

The release notes entry in the PR body needs to be a level two header:

Oscar.jl/dev/releases/release_notes.py

Line 179 in 91e2df4

index1 = body.lower().find("## release notes")

but it is level one.

I will try changing the message and re-running it.

After two more adjustments this did work:

The itemize needs to be done with - some text and not * some text

The list should not contain the PR link #1234 at the beginning since it will be added automatically.

Maybe the script can be adjusted further to be able to deal with these things but for now it did seem to work:

#### New features or extended functionality - [#5032](https://github.com/oscar-system/Oscar.jl/pull/5032) Improve vector of minimal exponents method for cohomology computations - [#5512](https://github.com/oscar-system/Oscar.jl/pull/5512) **Breaking:** Rename `all_cohomologies` to `sheaf_cohomology` - [#5512](https://github.com/oscar-system/Oscar.jl/pull/5512) Support line bundle cohomology computation via local cohomology, including functorial aspects.

I discussed this with @aaruni96 and he'll improve the script: instead of inserting "garbage", it will insert a suitable message about a parsing problem or so

I would suggest that we also make the script handle lists formatted with * instead of -.

benlorenz · 2025-11-27T16:30:24Z

@fingolfin @aaruni96 @lgoettgens What is the status of this now? If we want to create a release maybe tomorrow morning then this need to be completed, I just re-ran the script for 1.6.0 and it looks reasonable to me.
I just restarted the tests on #5578 (since the new singular.jl was released earlier today), and I guess this would be good to get in.

aaruni96 · 2025-11-27T16:33:42Z

I think the comments to improve the changelog script don't need to go in Oscar 1.6.0. Right now, with the current changes, the script produces a good changelog. The improvements suggested by @fingolfin above (to better handle strange cases, and accept * as list items) were not on my todo list for new release.

However, I can most likely make those changes by EOD, in case those changes should be made ASAP.

benlorenz · 2025-11-27T16:52:43Z

My comment was mostly regarding the changelog itself, not the script. I also think that further updates to the script can be done later. The current changelog in this PR looks good to me.

fingolfin

Looks good to me up to some very minor details in PR titles: I tweaked some (and saw someone else tweaked some more), so maybe we regenerate this a final time and then merge it?

lgoettgens

I just did two more minor consistency changes and regenerated. LGTM now.

lgoettgens marked this pull request as draft November 12, 2025 11:17

github-actions Bot force-pushed the update-changelog branch from 6227309 to 8f9b5b3 Compare November 12, 2025 11:32

lgoettgens reviewed Nov 12, 2025

View reviewed changes

Comment thread CHANGELOG.md Outdated

lgoettgens reviewed Nov 12, 2025

View reviewed changes

github-actions Bot force-pushed the update-changelog branch from 8f9b5b3 to 06019bf Compare November 12, 2025 21:22

lgoettgens reviewed Nov 12, 2025

View reviewed changes

lgoettgens mentioned this pull request Nov 13, 2025

Changelog script: multiple changelog entries for a single PR #5279

Merged

aaruni96 mentioned this pull request Nov 19, 2025

Changelog script: Add a general section to release notes for PRs without type labels #5565

Merged

github-actions Bot force-pushed the update-changelog branch 4 times, most recently from 2352b02 to 8c2a646 Compare November 26, 2025 15:05

fingolfin reviewed Nov 26, 2025

View reviewed changes

github-actions Bot force-pushed the update-changelog branch 5 times, most recently from 6f6bf4d to 5819e27 Compare November 27, 2025 16:20

github-actions Bot force-pushed the update-changelog branch from 5819e27 to cd66b41 Compare November 28, 2025 09:13

aaruni96 mentioned this pull request Feb 3, 2026

Changelog script: minor complaints oscar-system/update-release-notes#7

Closed

fingolfin reviewed Nov 28, 2025

View reviewed changes

Comment thread CHANGELOG.md Outdated

lgoettgens reviewed Nov 28, 2025

View reviewed changes

Comment thread CHANGELOG.md Outdated

fingolfin approved these changes Nov 28, 2025

View reviewed changes

github-actions Bot force-pushed the update-changelog branch from cd66b41 to 1ec41c2 Compare November 28, 2025 13:58

benlorenz marked this pull request as ready for review November 28, 2025 14:00

This comment was marked as outdated.

Sign in to view

benlorenz mentioned this pull request Nov 28, 2025

bump version to 1.7.0-DEV #5602

Merged

Update changelog on 2025-11-28

e9496d6

github-actions Bot force-pushed the update-changelog branch from 1ec41c2 to e9496d6 Compare November 28, 2025 14:22

lgoettgens approved these changes Nov 28, 2025

View reviewed changes

benlorenz merged commit 8d86e96 into master Nov 28, 2025

benlorenz deleted the update-changelog branch November 28, 2025 14:31

lgoettgens added the release notes: not needed PRs introducing changes that are wholly irrelevant to the release notes label Nov 28, 2025


		### TODO insufficient labels for automatic classification

		The following PRs only have a topic label assigned to them, not a PR type. Either assign a type label to them (e.g., `enhancement`), or manually move them to the general section of the topic section in the changelog.


		Ping @HereAround , @friedemann2.

		~~Note: I can not test this version locally at the moment because with the latest master branch in Oscar.jl my julia is complaining about an incompatibility with GAP and I can somehow not resolve this issue with the usual updating procedures. I plan to clean this branch up a little further, once it works on my machine again.~~ Had to throw away my `~/.julia` folder; now it seems to work. Still working on the updates, though.

Conversation

github-actions Bot commented Nov 12, 2025

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

aaruni96 Nov 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

joschmitt commented Nov 12, 2025

Uh oh!

lgoettgens commented Nov 12, 2025

Uh oh!

aaruni96 commented Nov 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

joschmitt commented Nov 13, 2025

Uh oh!

fingolfin commented Nov 13, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

benlorenz commented Nov 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

aaruni96 commented Nov 27, 2025

Uh oh!

benlorenz commented Nov 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

fingolfin left a comment

Choose a reason for hiding this comment

Uh oh!

This comment was marked as outdated.

lgoettgens left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

aaruni96 Nov 12, 2025 •

edited

Loading

aaruni96 commented Nov 12, 2025 •

edited

Loading

benlorenz commented Nov 27, 2025 •

edited

Loading

benlorenz commented Nov 27, 2025 •

edited

Loading