Fix raising matrix group elements to negative powers#5594
Merged
fingolfin merged 1 commit intooscar-system:masterfrom Nov 26, 2025
Merged
Fix raising matrix group elements to negative powers#5594fingolfin merged 1 commit intooscar-system:masterfrom
fingolfin merged 1 commit intooscar-system:masterfrom
Conversation
If the underlying matrix is a `ZZMatrix` then negative exponents are not allowed.
Member
|
This |
fingolfin
approved these changes
Nov 26, 2025
Collaborator
|
Would fixing powering for |
Member
Author
It is not clear for me that "fixing" is the right term, my understanding was that the If we want to change this then this is fine. (The change belongs to Nemo.jl. |
Collaborator
|
Hm, since we don't error here: I think we should also not error in the matrix case. I'll adjust it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the underlying matrix is a
ZZMatrixthen negative exponents are not allowed.(addresses a problem mentioned in #5550)
Note that the situation is a bit tricky:
The reason for that is some
literal_powmagic from AbstractAlgebra.We might do the same for
ZZMatrix.