Check that all variables are from the same ring when generating an ordering#5596
Merged
simonbrandhorst merged 4 commits intooscar-system:masterfrom Dec 1, 2025
Merged
Conversation
ederc
added
bug
joschmitt
previously requested changes
Nov 27, 2025
joschmitt
reviewed
Nov 27, 2025
Member
|
@ederc, a gentle reminder that this PR has a "release notes: to be added" label. Please add release notes using one of the other label options (see https://docs.oscar-system.org/dev/DeveloperDocumentation/changelog/#Primary-Labels:-Release-Notes-Behaviour) so that we can include this in the v1.7.0 release notes. |
ederc
added
the
release notes: use title
lgoettgens
added
topic: commutative algebra
and removed
release notes: to be added
fingolfin
changed the title
benlorenz
referenced
this pull request
Feb 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a check that all variables are from the same ring when generating an ordering, see side note in #5590.