Improve normal_cone to support multiple vertices as input, and provide an option for calculating outer or inner normal cones.

[atahan2000]

This is the first time I am doing it so I am open to any tips.

The things I have done:

1. Improved the normal_cone in PolyhedralGeometry to include multiple vertices like in polymake.
2. Putting an option to change from calculating outer to inner normal cones.
3. Edited the documentation above the function.

[lkastner]

Thank you, this will be a valuable contribution. Once the tests run I will have another look.

[atahan2000]

I manually changed the things you have said, I am not sure whether there is an easier way to do it but, looking forward to your new suggestions!

[fingolfin]

Thank you!

Unfortunately code formatting is off, this can be fixed by running julia etc/format_code.jl in the Oscar.jl directory (and then committing the resulting changes).

Also, may I suggest that you use the "Resolve conversation" on any discussion you already addressed? That makes it a bit easier to follow along (I did it for some this morning, but more things have been changed by now)

[fingolfin]

I've modified the title to be in a form usable for our release notes; but I don't know enough about this topic to decide if it is sensible, so please double-check and edit it as needed.

[atahan2000]

Thanks for all the help and patience. I have only book-tests (nightly) error in the checks now. Didn't understand much about it, can you help me.

[fingolfin]

The booktest failures with Julia nightly are "normal" (see #5592); in general any tests against Julia normal can fail, and you don't need to worry about that (basically only those tests marked as "Required" are, well, required :-))

[atahan2000]

I also rewrote the title like you said, its just rewording but felt more natural this way. Thank you for your patience, this was my first commit. Looks everything fine now then?

[benlorenz]

Can you also add a few testcases in the proper testsuite (in addition to the doctest), e.g. below this one:

Oscar.jl/test/PolyhedralGeometry/polyhedron.jl

Lines 282 to 284 in e1327cf

	nc = normal_cone(square, 1)
	@test nc isa Cone{T}
	@test rays(nc) == [[1, 0], [0, 1]]

These will run in more different configurations than the doctests.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.07%. Comparing base (131f5bf) to head (0d2d575).
⚠️ Report is 14 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #5610      +/-   ##
==========================================
+ Coverage   84.06%   84.07%   +0.01%     
==========================================
  Files         744      744              
  Lines      101320   101373      +53     
==========================================
+ Hits        85170    85229      +59     
+ Misses      16150    16144       -6     

Files with missing lines	Coverage Δ
...edralGeometry/Polyhedron/standard_constructions.jl	97.38% <100.00%> (+<0.01%)	⬆️

... and 12 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[atahan2000]

⚠️ Report is 13 commits behind head on master.

Do I have to do anything about it?

[lkastner]

Thank you.

[benlorenz]

⚠️ Report is 13 commits behind head on master.

Do I have to do anything about it?

No, this is fine. Also the two failures on nightly are tracked in other issues.

[atahan2000]

Thank you all for the feedbacks and help! :-)