Skip to content

Extend betti_numbers for SimplicialComplex to allow computing Betti numbers over a field instead of the integers#5618

Merged
antonydellavecchia merged 15 commits intomasterfrom
adv/betti-numbers-char-p
Feb 2, 2026
Merged

Extend betti_numbers for SimplicialComplex to allow computing Betti numbers over a field instead of the integers#5618
antonydellavecchia merged 15 commits intomasterfrom
adv/betti-numbers-char-p

Conversation

@antonydellavecchia
Copy link
Copy Markdown
Collaborator

Extend betti_numbers function to accept optional parameter for the Field

@antonydellavecchia antonydellavecchia added topic: combinatorics release notes: use title For PRs: the title of this PR is suitable for direct use in the release notes labels Dec 2, 2025
Comment thread src/Combinatorics/SimplicialComplexes.jl Outdated
Comment thread src/Combinatorics/SimplicialComplexes.jl Outdated
Comment thread src/Combinatorics/SimplicialComplexes.jl Outdated
Comment thread src/Combinatorics/SimplicialComplexes.jl Outdated
@lgoettgens lgoettgens changed the title Betti numbers over a given field betti_numbers(::SimplicialComplex) over a given field Dec 2, 2025
Copy link
Copy Markdown
Collaborator

@HechtiDerLachs HechtiDerLachs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it would be worthwhile to add
betti_numbers(R::Ring, S::SimplicialComplex) = betti_numbers(characteristic(R), S) ?
And betti_number([p::Int], S::SimplicialComplex, i::Int) to return only a single Betti number?

Another question I had: The function returns a list of integers. Is it clear that the first entry always stands for the 0-th Betti number, the second for the first, etc.? If yes, everything is fine. But otherwise, one could think of returning a dictionary?

Sorry for the delayed review, btw. The request slipped me through. Feel free to ping me through other channels if this happens again.

Comment thread src/Combinatorics/SimplicialComplexes.jl Outdated
Comment thread src/Combinatorics/SimplicialComplexes.jl Outdated
@fingolfin
Copy link
Copy Markdown
Member

@antonydellavecchia what's the status of this? Should it be re-reviewed?

@fingolfin
Copy link
Copy Markdown
Member

@HechtiDerLachs will talk to @antonydellavecchia about this, they wanted to meet later today anyway.

@antonydellavecchia
Copy link
Copy Markdown
Collaborator Author

@antonydellavecchia what's the status of this? Should it be re-reviewed?

I'll implement what @HechtiDerLachs suggested above at some point today or this week

Comment thread src/Combinatorics/SimplicialComplexes.jl Outdated
Copy link
Copy Markdown
Collaborator

@HechtiDerLachs HechtiDerLachs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Kept simple.

Edit: Wait! Sorry. Now the signature is for Rings. But can we assume that the rank command works then on the matrices? Do we want to assume that?

Comment thread src/Combinatorics/SimplicialComplexes.jl Outdated
Comment thread src/Combinatorics/SimplicialComplexes.jl Outdated
@antonydellavecchia antonydellavecchia merged commit 4fc5e66 into master Feb 2, 2026
53 of 63 checks passed
@antonydellavecchia antonydellavecchia deleted the adv/betti-numbers-char-p branch February 2, 2026 09:06
@fingolfin fingolfin added the enhancement New feature or request label Feb 12, 2026
@fingolfin fingolfin changed the title betti_numbers(::SimplicialComplex) over a given field Extend betti_numbers for SimplicialComplex to allow computing Betti number over a field instead of the integers Feb 12, 2026
@fingolfin fingolfin changed the title Extend betti_numbers for SimplicialComplex to allow computing Betti number over a field instead of the integers Extend betti_numbers for SimplicialComplex to allow computing Betti numbers over a field instead of the integers Feb 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request release notes: use title For PRs: the title of this PR is suitable for direct use in the release notes topic: combinatorics

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants