Automatic generation of ample classes for elliptic surfaces

[simonbrandhorst]

Release Notes

• Fix a bug in K3_surface_automorphism_group {bug}
• Add ample_class for EllipticSurface {enhancement}

[simonbrandhorst]

@ericpipha

[HechtiDerLachs]

Looks plausible. A docstring for is_nef could help to give a bit more context to the input. I suppose that the vector for the second argument stands for a class in the algebraic_lattice. What do we do if that lattice is not yet known? Does the user need to make sure some data is set beforehand? Such things might be helpful.

[lgoettgens]

If you use the release notes: use body label, please follow the syntax as explained in https://docs.oscar-system.org/dev/DeveloperDocumentation/changelog/#Release-Notes:-Use-Body.

[simonbrandhorst]

O.K. then we just use the title.
@HechtiDerLachs should be good to go now.

[HechtiDerLachs]

Looks good.

[fingolfin]

@simonbrandhorst @HechtiDerLachs this title is not very clear. Is this a new feature (if so, how would a user reach it), or is it a bug fix, or what? There is also no label indicating that, perhaps you can one or more appropriate ones?