Allow field coercion and pre-set coefficient fields for polyhedra#5670
Merged
Allow field coercion and pre-set coefficient fields for polyhedra#5670
Conversation
benlorenz
added
topic: polyhedral geometry
Collaborator
|
I ran the tests here against thofma/Hecke.jl#2116 and they passed. Are there more things to be tested or should I make a release? |
Member
Author
I think this is fine now, thanks! I ran a more expensive loop (which I don't want to put in the tests): julia> for i in 1:92
p = johnson_solid(i)
print("$i: ")
try
print(qqb(volume(p))," - "); println(qqb(volume(p)) == volume(johnson_solid(qqb,i)))
catch e
println("failed")
end
endNo errors until number 88. This one is stuck in the convex hull computations right now but only because it needs quite involved polynomials... |
Collaborator
|
The fix is available in Hecke version 0.36.7. |
benlorenz
changed the title
(doesn't preserve sparseness)
benlorenz
force-pushed
the
bl/coerce_polyhedron
branch
from
12aa43d to
6d1d8c8
Compare
lkastner
approved these changes
Jan 5, 2026
varuntrehan7
pushed a commit
to varuntrehan7/Oscar.jl
that referenced
this pull request
Jan 14, 2026
lgoettgens
changed the title
benlorenz
referenced
this pull request
Feb 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Waiting for some more fixes in Hecke, fixes #5667.