Skip to content

Update changelog#5690

Merged
benlorenz merged 1 commit intorelease-1.7from
update-changelog
Feb 13, 2026
Merged

Update changelog#5690
benlorenz merged 1 commit intorelease-1.7from
update-changelog

Conversation

@github-actions
Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot commented Jan 8, 2026

Automated changes by create-pull-request GitHub action

@aaruni96 aaruni96 marked this pull request as draft January 8, 2026 20:08
@github-actions github-actions Bot force-pushed the update-changelog branch 2 times, most recently from 902c06f to 236b717 Compare February 2, 2026 10:12
Comment thread CHANGELOG.md Outdated
### Changes related to the package AbstractAlgebra

- [#5710](https://github.com/oscar-system/Oscar.jl/pull/5710) Update AbstractAlgebra to v0.48
- [#5710](https://github.com/oscar-system/Oscar.jl/pull/5710) Update Nemo to v0.54
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aaruni96 there seems to be a bug in the changelog script. This entry is taken from a "use body" label, where it is set to {package: Nemo}. However, it appears here in the AA section (and not in the Nemo one)

Copy link
Copy Markdown
Member

@aaruni96 aaruni96 Feb 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see what has happened.

The script looks at the label (given by {package: Nemo}, and indeed does attach it to the copy of 5170.

But, it is assumed that a PR will only have one "topic" label. Since #5710 itself has labels for both AA and nemo, the script just goes through the labels defined in dev/releases/config.toml, and puts the PR under the first label it finds. Since AA is in line 18, and Nemo is in line 22 in dev/releases/config.toml, AA "wins".

Quick fix: remove both labels form #5710, and then it will work as expected again.
Long term fix: I am not sure, and will have to think about the best way of resolving this.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually I think this is fine: the package: AbstractAlgebra and package: Nemo labels should not have been on #5710 itself, only on its various entries.

As to fix: it would of course be good if this was caught, but I'd say it should result in an error. Specifically, raise an error if a label is attached to both the PR itself, and one (or multiple, doesn't matter) of the bullet points. In that case, suggest removing the label from the PR.

@github-actions github-actions Bot force-pushed the update-changelog branch 2 times, most recently from e49e352 to b187b58 Compare February 5, 2026 15:13
@fingolfin fingolfin mentioned this pull request Feb 12, 2026
@github-actions github-actions Bot force-pushed the update-changelog branch 4 times, most recently from 86b5020 to e7c3f35 Compare February 12, 2026 23:57
@benlorenz benlorenz changed the base branch from master to release-1.7 February 13, 2026 08:31
@benlorenz benlorenz added the release notes: not needed PRs introducing changes that are wholly irrelevant to the release notes label Feb 13, 2026
@benlorenz benlorenz marked this pull request as ready for review February 13, 2026 08:32
@benlorenz benlorenz merged commit 653d1dc into release-1.7 Feb 13, 2026
1 of 2 checks passed
@benlorenz benlorenz deleted the update-changelog branch February 13, 2026 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release notes: not needed PRs introducing changes that are wholly irrelevant to the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants