Conversation
b7a2934 to
35c82a6
Compare
35c82a6 to
59811be
Compare
902c06f to
236b717
Compare
| ### Changes related to the package AbstractAlgebra | ||
|
|
||
| - [#5710](https://github.com/oscar-system/Oscar.jl/pull/5710) Update AbstractAlgebra to v0.48 | ||
| - [#5710](https://github.com/oscar-system/Oscar.jl/pull/5710) Update Nemo to v0.54 |
There was a problem hiding this comment.
@aaruni96 there seems to be a bug in the changelog script. This entry is taken from a "use body" label, where it is set to {package: Nemo}. However, it appears here in the AA section (and not in the Nemo one)
There was a problem hiding this comment.
I see what has happened.
The script looks at the label (given by {package: Nemo}, and indeed does attach it to the copy of 5170.
But, it is assumed that a PR will only have one "topic" label. Since #5710 itself has labels for both AA and nemo, the script just goes through the labels defined in dev/releases/config.toml, and puts the PR under the first label it finds. Since AA is in line 18, and Nemo is in line 22 in dev/releases/config.toml, AA "wins".
Quick fix: remove both labels form #5710, and then it will work as expected again.
Long term fix: I am not sure, and will have to think about the best way of resolving this.
There was a problem hiding this comment.
Actually I think this is fine: the package: AbstractAlgebra and package: Nemo labels should not have been on #5710 itself, only on its various entries.
As to fix: it would of course be good if this was caught, but I'd say it should result in an error. Specifically, raise an error if a label is attached to both the PR itself, and one (or multiple, doesn't matter) of the bullet points. In that case, suggest removing the label from the PR.
e49e352 to
b187b58
Compare
b187b58 to
67fd2e1
Compare
86b5020 to
e7c3f35
Compare
e7c3f35 to
a700541
Compare
Automated changes by create-pull-request GitHub action