Rename MatrixGroup, MatrixGroupElem to MatGroup, MatGroupElem, to better fit in with MatElem and MatRingElem#5704
Merged
ThomasBreuer merged 5 commits intomasterfrom Jan 16, 2026
Merged
Conversation
fingolfin
added
topic: groups
renaming
release notes: use title
fingolfin
changed the title
MatrixGroup, MatrixGroupElem etc. to MatGroup, MatGroupElem etc., to better fit in with MatElem and MatRingElemMatrixGroup, MatrixGroupElem to MatGroup, MatGroupElem, to better fit in with MatElem and MatRingElem
ThomasBreuer
approved these changes
Jan 16, 2026
Member
ThomasBreuer
left a comment
ThomasBreuer
left a comment
There was a problem hiding this comment.
Looks good.
Why did you remove the "etc." from the title (also AbstractMatrixGroupElem. ZZMatrixGroup, QQMatrixGroup got changed)?
simonbrandhorst
approved these changes
Jan 16, 2026
fingolfin
changed the title
MatrixGroup, MatrixGroupElem to MatGroup, MatGroupElem, to better fit in with MatElem and MatRingElemMatrixGroup, MatrixGroupElem to MatGroup, MatGroupElem, to better fit in with MatElem and MatRingElem
benlorenz
referenced
this pull request
Feb 13, 2026
Member
|
Coming back to this pull request: Has anybody made an update of serialization scripts which takes this into account ? I have tried to load some data with old |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #5649
I split the work into several commits, and made sure not to touch things like the module name
MatrixGroupsor the GAP functionIsMatrixGroup.