Fix deserialization of SMat with trailing zero cols#5850
Merged
antonydellavecchia merged 1 commit intooscar-system:masterfrom Mar 10, 2026
Merged
Fix deserialization of SMat with trailing zero cols#5850antonydellavecchia merged 1 commit intooscar-system:masterfrom
SMat with trailing zero cols#5850antonydellavecchia merged 1 commit intooscar-system:masterfrom
Conversation
lgoettgens
added
serialization
release notes: use title
joschmitt
changed the title
SMat with trailing zero colsSMat with trailing zero cols
antonydellavecchia
approved these changes
Mar 9, 2026
Collaborator
antonydellavecchia
left a comment
antonydellavecchia
left a comment
There was a problem hiding this comment.
Looks good given the circumstances
benlorenz
pushed a commit
that referenced
this pull request
Mar 23, 2026
(cherry picked from commit dd4be64)
benlorenz
referenced
this pull request
Mar 26, 2026
Kazak-11
pushed a commit
to Kazak-11/Oscar.jl
that referenced
this pull request
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #5849.
However, what I add here seems more like a hack. I would prefer if the SMatSpace had some proper interface to do these things (or even to do them automatically), but this is an immediate fix to the issue that can be cleaned up eventually.